From bc9ae62f30d5dbc9996e4bb720d5828b110dca52 Mon Sep 17 00:00:00 2001 From: Anton Makeev Date: Thu, 14 Feb 2013 13:13:13 +0100 Subject: [PATCH] Updater: handling OOM errors (and other), increased Xmx for updater process --- platform/bootstrap/src/com/intellij/idea/Main.java | 1 + updater/src/com/intellij/updater/Patch.java | 2 +- updater/src/com/intellij/updater/SwingUpdaterUI.java | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/platform/bootstrap/src/com/intellij/idea/Main.java b/platform/bootstrap/src/com/intellij/idea/Main.java index 9a0f753104df..bc20847531c2 100644 --- a/platform/bootstrap/src/com/intellij/idea/Main.java +++ b/platform/bootstrap/src/com/intellij/idea/Main.java @@ -139,6 +139,7 @@ public class Main { Collections.addAll(args, System.getProperty("java.home") + "/bin/java", + "-Xmx700m", "-classpath", copyPatchFile.getPath(), "com.intellij.updater.Runner", diff --git a/updater/src/com/intellij/updater/Patch.java b/updater/src/com/intellij/updater/Patch.java index ac787afd50b0..71a9a520361c 100644 --- a/updater/src/com/intellij/updater/Patch.java +++ b/updater/src/com/intellij/updater/Patch.java @@ -200,7 +200,7 @@ public class Patch { shouldRevert = true; cancelled = true; } - catch (Exception e) { + catch (Throwable e) { shouldRevert = true; ui.showError(e); } diff --git a/updater/src/com/intellij/updater/SwingUpdaterUI.java b/updater/src/com/intellij/updater/SwingUpdaterUI.java index 7d28d444519a..64df6367ea97 100644 --- a/updater/src/com/intellij/updater/SwingUpdaterUI.java +++ b/updater/src/com/intellij/updater/SwingUpdaterUI.java @@ -187,6 +187,9 @@ public class SwingUpdaterUI implements UpdaterUI { } catch (OperationCancelledException ignore) { } + catch(Throwable e) { + showError(e); + } finally { isRunning.set(false);