diff --git a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ImplementMethodsFix.java b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ImplementMethodsFix.java index 592b856b2ea1..667e8ed8884b 100644 --- a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ImplementMethodsFix.java +++ b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ImplementMethodsFix.java @@ -22,11 +22,10 @@ import com.intellij.codeInsight.generation.PsiMethodMember; import com.intellij.codeInsight.intention.impl.ImplementAbstractMethodHandler; import com.intellij.codeInspection.IntentionAndQuickFixAction; import com.intellij.featureStatistics.FeatureUsageTracker; +import com.intellij.featureStatistics.ProductivityFeatureNames; import com.intellij.ide.util.MemberChooser; -import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.application.Result; import com.intellij.openapi.command.WriteCommandAction; -import com.intellij.openapi.diagnostic.Logger; import com.intellij.openapi.editor.Editor; import com.intellij.openapi.project.Project; import com.intellij.psi.*; @@ -36,7 +35,6 @@ import com.intellij.util.containers.HashMap; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; -import java.util.Collection; import java.util.Collections; import java.util.List; import java.util.TreeMap; @@ -64,7 +62,7 @@ public class ImplementMethodsFix extends IntentionAndQuickFixAction { public void applyFix(final Project project, final PsiFile file, @Nullable final Editor editor) { if (editor == null || !CodeInsightUtilBase.prepareFileForWrite(myPsiElement.getContainingFile())) return; if (myPsiElement instanceof PsiEnumConstant) { - FeatureUsageTracker.getInstance().triggerFeatureUsed("codeassists.overrideimplement"); + FeatureUsageTracker.getInstance().triggerFeatureUsed(ProductivityFeatureNames.CODEASSISTS_OVERRIDE_IMPLEMENT); final TreeMap result = new TreeMap(new OverrideImplementUtil.MethodSignatureComparator()); final HashMap abstracts = new HashMap(); diff --git a/java/java-impl/src/com/intellij/codeInsight/generation/OverrideImplementUtil.java b/java/java-impl/src/com/intellij/codeInsight/generation/OverrideImplementUtil.java index 4e9e83fd999e..8ad10f9f9dc7 100644 --- a/java/java-impl/src/com/intellij/codeInsight/generation/OverrideImplementUtil.java +++ b/java/java-impl/src/com/intellij/codeInsight/generation/OverrideImplementUtil.java @@ -21,6 +21,7 @@ import com.intellij.codeInsight.CodeInsightBundle; import com.intellij.codeInsight.MethodImplementor; import com.intellij.codeInsight.intention.AddAnnotationFix; import com.intellij.featureStatistics.FeatureUsageTracker; +import com.intellij.featureStatistics.ProductivityFeatureNames; import com.intellij.ide.fileTemplates.FileTemplate; import com.intellij.ide.fileTemplates.FileTemplateManager; import com.intellij.ide.fileTemplates.FileTemplateUtil; @@ -455,12 +456,12 @@ public class OverrideImplementUtil { } public static void chooseAndOverrideMethods(Project project, Editor editor, PsiClass aClass){ - FeatureUsageTracker.getInstance().triggerFeatureUsed("codeassists.overrideimplement"); + FeatureUsageTracker.getInstance().triggerFeatureUsed(ProductivityFeatureNames.CODEASSISTS_OVERRIDE_IMPLEMENT); chooseAndOverrideOrImplementMethods(project, editor, aClass, false); } public static void chooseAndImplementMethods(Project project, Editor editor, PsiClass aClass){ - FeatureUsageTracker.getInstance().triggerFeatureUsed("codeassists.overrideimplement"); + FeatureUsageTracker.getInstance().triggerFeatureUsed(ProductivityFeatureNames.CODEASSISTS_OVERRIDE_IMPLEMENT); chooseAndOverrideOrImplementMethods(project, editor, aClass, true); } diff --git a/java/java-impl/src/com/intellij/codeInsight/highlighting/HighlightExitPointsHandler.java b/java/java-impl/src/com/intellij/codeInsight/highlighting/HighlightExitPointsHandler.java index 23314813264f..2fce52aaf437 100644 --- a/java/java-impl/src/com/intellij/codeInsight/highlighting/HighlightExitPointsHandler.java +++ b/java/java-impl/src/com/intellij/codeInsight/highlighting/HighlightExitPointsHandler.java @@ -17,6 +17,7 @@ package com.intellij.codeInsight.highlighting; import com.intellij.codeInsight.CodeInsightBundle; import com.intellij.featureStatistics.FeatureUsageTracker; +import com.intellij.featureStatistics.ProductivityFeatureNames; import com.intellij.openapi.editor.Editor; import com.intellij.openapi.project.Project; import com.intellij.psi.*; @@ -48,7 +49,7 @@ public class HighlightExitPointsHandler extends HighlightUsagesHandlerBase targets) { - FeatureUsageTracker.getInstance().triggerFeatureUsed("codeassists.highlight.return"); + FeatureUsageTracker.getInstance().triggerFeatureUsed(ProductivityFeatureNames.CODEASSISTS_HIGHLIGHT_RETURN); PsiElement parent = myTarget.getParent(); if (!(parent instanceof PsiReturnStatement) && !(parent instanceof PsiThrowStatement)) return; diff --git a/java/java-impl/src/com/intellij/refactoring/introduceVariable/IntroduceVariableBase.java b/java/java-impl/src/com/intellij/refactoring/introduceVariable/IntroduceVariableBase.java index 2e95f0d34778..34367c1520e5 100644 --- a/java/java-impl/src/com/intellij/refactoring/introduceVariable/IntroduceVariableBase.java +++ b/java/java-impl/src/com/intellij/refactoring/introduceVariable/IntroduceVariableBase.java @@ -21,6 +21,7 @@ import com.intellij.codeInsight.highlighting.HighlightManager; import com.intellij.codeInsight.intention.impl.TypeExpression; import com.intellij.codeInsight.lookup.LookupManager; import com.intellij.featureStatistics.FeatureUsageTracker; +import com.intellij.featureStatistics.ProductivityFeatureNames; import com.intellij.ide.util.PropertiesComponent; import com.intellij.lang.LanguageRefactoringSupport; import com.intellij.lang.refactoring.RefactoringSupportProvider; @@ -187,7 +188,7 @@ public abstract class IntroduceVariableBase extends IntroduceHandlerBase impleme } private boolean invoke(final Project project, final Editor editor, PsiFile file, int startOffset, int endOffset) { - FeatureUsageTracker.getInstance().triggerFeatureUsed("refactoring.introduceVariable"); + FeatureUsageTracker.getInstance().triggerFeatureUsed(ProductivityFeatureNames.REFACTORING_INTRODUCE_VARIABLE); PsiDocumentManager.getInstance(project).commitAllDocuments(); diff --git a/platform/platform-api/src/com/intellij/featureStatistics/ProductivityFeatureNames.java b/platform/platform-api/src/com/intellij/featureStatistics/ProductivityFeatureNames.java new file mode 100644 index 000000000000..a89d8d98e58b --- /dev/null +++ b/platform/platform-api/src/com/intellij/featureStatistics/ProductivityFeatureNames.java @@ -0,0 +1,25 @@ +/* + * Copyright 2000-2011 JetBrains s.r.o. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.intellij.featureStatistics; + +public class ProductivityFeatureNames { + public static final String CODEASSISTS_HIGHLIGHT_RETURN = "codeassists.highlight.return"; + public static final String REFACTORING_INTRODUCE_VARIABLE = "refactoring.introduceVariable"; + public static final String CODEASSISTS_OVERRIDE_IMPLEMENT = "codeassists.overrideimplement"; + + private ProductivityFeatureNames() { + } +}