diff --git a/plugins/groovy/src/org/jetbrains/plugins/groovy/refactoring/changeSignature/GrParameterInfo.java b/plugins/groovy/src/org/jetbrains/plugins/groovy/refactoring/changeSignature/GrParameterInfo.java index 270135255e79..5b81388bc112 100644 --- a/plugins/groovy/src/org/jetbrains/plugins/groovy/refactoring/changeSignature/GrParameterInfo.java +++ b/plugins/groovy/src/org/jetbrains/plugins/groovy/refactoring/changeSignature/GrParameterInfo.java @@ -103,8 +103,7 @@ public class GrParameterInfo implements JavaParameterInfo { } public PsiExpression getValue(PsiCallExpression callExpression) { - return JavaPsiFacade.getInstance(callExpression.getProject()).getElementFactory() - .createExpressionFromText(myDefaultValue, callExpression); + return JavaPsiFacade.getElementFactory(callExpression.getProject()).createExpressionFromText(getDefaultValue(), callExpression); } public boolean isVarargType() { diff --git a/plugins/groovy/test/org/jetbrains/plugins/groovy/refactoring/changeSignature/ChangeSignatureTest.java b/plugins/groovy/test/org/jetbrains/plugins/groovy/refactoring/changeSignature/ChangeSignatureTest.java index cfbfa451cb2d..316e605459ff 100644 --- a/plugins/groovy/test/org/jetbrains/plugins/groovy/refactoring/changeSignature/ChangeSignatureTest.java +++ b/plugins/groovy/test/org/jetbrains/plugins/groovy/refactoring/changeSignature/ChangeSignatureTest.java @@ -240,6 +240,10 @@ public class ChangeSignatureTest extends ChangeSignatureTestCase { doTest(new SimpleInfo("newName", 0), new SimpleInfo(1)); } + public void testDefaultInitializerInJava() { + doTest(new SimpleInfo("p", -1, "", "1", "")); + } + private PsiType createType(String typeText) { return JavaPsiFacade.getElementFactory(getProject()).createTypeByFQClassName(typeText, GlobalSearchScope.allScope(getProject())); } diff --git a/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava.groovy b/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava.groovy new file mode 100644 index 000000000000..7ae2a99dca0b --- /dev/null +++ b/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava.groovy @@ -0,0 +1,3 @@ +class GClass { + public void test() {} +} \ No newline at end of file diff --git a/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava.java b/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava.java new file mode 100644 index 000000000000..5fdb3fed54fb --- /dev/null +++ b/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava.java @@ -0,0 +1,5 @@ +public class JClass { + void doTest() { + new GClass().test(); + } +} diff --git a/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava_after.groovy b/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava_after.groovy new file mode 100644 index 000000000000..a96448e49cf8 --- /dev/null +++ b/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava_after.groovy @@ -0,0 +1,3 @@ +class GClass { + public test(def p = 1) {} +} \ No newline at end of file diff --git a/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava_after.java b/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava_after.java new file mode 100644 index 000000000000..81b19989d6e8 --- /dev/null +++ b/plugins/groovy/testdata/refactoring/changeSignature/DefaultInitializerInJava_after.java @@ -0,0 +1,5 @@ +public class JClass { + void doTest() { + new GClass().test(1); + } +}