diff --git a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraryEditor/ItemElementDescriptor.java b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraryEditor/ItemElementDescriptor.java index 15f28ee10549..aba61f0ce177 100644 --- a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraryEditor/ItemElementDescriptor.java +++ b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraryEditor/ItemElementDescriptor.java @@ -37,7 +37,7 @@ class ItemElementDescriptor extends NodeDescriptor { myElement = element; final String url = element.getUrl(); myName = getPresentablePath(url).replace('/', File.separatorChar); - myIcon = getIconForUrl(url, element.isValid(), element.isJarDirectory()); + setIcon(getIconForUrl(url, element.isValid(), element.isJarDirectory())); } public boolean update() { diff --git a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraryEditor/OrderRootTypeElementDescriptor.java b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraryEditor/OrderRootTypeElementDescriptor.java index cd179217f421..edc55c74e7a8 100644 --- a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraryEditor/OrderRootTypeElementDescriptor.java +++ b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraryEditor/OrderRootTypeElementDescriptor.java @@ -26,7 +26,7 @@ public class OrderRootTypeElementDescriptor extends NodeDescriptor { private final NodeDescriptor myParentDescriptor; protected String myName; - protected Icon myIcon; + protected Icon myClosedIcon; + + /** + * Unused. It's there only for API compatibility. + */ + @Deprecated + protected Icon myOpenIcon; protected Color myColor; private int myIndex = -1; @@ -80,7 +86,7 @@ public abstract class NodeDescriptor { } public final Icon getIcon() { - return myIcon; + return myClosedIcon; } public final Color getColor() { @@ -130,11 +136,15 @@ public abstract class NodeDescriptor { } public void applyFrom(NodeDescriptor desc) { - myIcon = desc.myIcon; + setIcon(desc.getIcon()); myName = desc.myName; myColor = desc.myColor; } + public void setIcon(Icon closedIcon) { + myClosedIcon = closedIcon; + } + public abstract static class NodeComparator implements Comparator { private long myStamp; @@ -179,4 +189,4 @@ public abstract class NodeDescriptor { } } } -} \ No newline at end of file +} diff --git a/platform/platform-api/src/com/intellij/ide/util/treeView/PresentableNodeDescriptor.java b/platform/platform-api/src/com/intellij/ide/util/treeView/PresentableNodeDescriptor.java index 6877de5e3c9a..c4add9f856f1 100644 --- a/platform/platform-api/src/com/intellij/ide/util/treeView/PresentableNodeDescriptor.java +++ b/platform/platform-api/src/com/intellij/ide/util/treeView/PresentableNodeDescriptor.java @@ -59,7 +59,7 @@ public abstract class PresentableNodeDescriptor extends NodeDescriptor { } protected final boolean apply(PresentationData presentation, @Nullable PresentationData before) { - myIcon = presentation.getIcon(false); + setIcon(presentation.getIcon(false)); myName = presentation.getPresentableText(); myColor = presentation.getForcedTextForeground(); boolean updated = before == null || !presentation.equals(before); @@ -231,4 +231,4 @@ public abstract class PresentableNodeDescriptor extends NodeDescriptor { return myName; } -} \ No newline at end of file +} diff --git a/platform/platform-api/src/com/intellij/ui/treeStructure/SimpleNode.java b/platform/platform-api/src/com/intellij/ui/treeStructure/SimpleNode.java index 2b3aa4e9e1e2..19e127fc3efc 100644 --- a/platform/platform-api/src/com/intellij/ui/treeStructure/SimpleNode.java +++ b/platform/platform-api/src/com/intellij/ui/treeStructure/SimpleNode.java @@ -93,7 +93,7 @@ public abstract class SimpleNode extends PresentableNodeDescriptor implements Co Color oldColor = myColor; String oldName = myName; - Icon oldIcon = myIcon; + Icon oldIcon = getIcon(); List oldFragments = new ArrayList(presentation.getColoredText()); myColor = UIUtil.getTreeTextForeground(); @@ -104,11 +104,11 @@ public abstract class SimpleNode extends PresentableNodeDescriptor implements Co myName = getName(); presentation.setPresentableText(myName); - presentation.setChanged(!Comparing.equal(new Object[]{myIcon, myName, oldFragments, myColor}, + presentation.setChanged(!Comparing.equal(new Object[]{getIcon(), myName, oldFragments, myColor}, new Object[]{oldIcon, oldName, oldFragments, oldColor})); presentation.setForcedTextForeground(myColor); - presentation.setIcon(myIcon); + presentation.setIcon(getIcon()); } protected void updateFileStatus() { @@ -241,7 +241,7 @@ public abstract class SimpleNode extends PresentableNodeDescriptor implements Co * or update presentation dynamically by defining {@link #update(com.intellij.ide.projectView.PresentationData)} */ public void setUniformIcon(Icon aIcon) { - myIcon = aIcon; + setIcon(aIcon); } /** diff --git a/platform/platform-impl/src/com/intellij/openapi/fileChooser/ex/FileNodeDescriptor.java b/platform/platform-impl/src/com/intellij/openapi/fileChooser/ex/FileNodeDescriptor.java index b299a6801869..1368a2703bf3 100644 --- a/platform/platform-impl/src/com/intellij/openapi/fileChooser/ex/FileNodeDescriptor.java +++ b/platform/platform-impl/src/com/intellij/openapi/fileChooser/ex/FileNodeDescriptor.java @@ -58,9 +58,9 @@ public class FileNodeDescriptor extends NodeDescriptor { if (file == null) return true; - myIcon = myOriginalIcon; + setIcon(myOriginalIcon); if (myFileElement.isHidden()) { - myIcon = IconLoader.getTransparentIcon(myIcon); + setIcon(IconLoader.getTransparentIcon(getIcon())); } myColor = myFileElement.isHidden() ? SimpleTextAttributes.DARK_TEXT.getFgColor() : null; return changed; diff --git a/plugins/ant/src/com/intellij/lang/ant/config/explorer/AntBuildFileNodeDescriptor.java b/plugins/ant/src/com/intellij/lang/ant/config/explorer/AntBuildFileNodeDescriptor.java index 90542c63b995..045841f81e11 100644 --- a/plugins/ant/src/com/intellij/lang/ant/config/explorer/AntBuildFileNodeDescriptor.java +++ b/plugins/ant/src/com/intellij/lang/ant/config/explorer/AntBuildFileNodeDescriptor.java @@ -54,7 +54,7 @@ final class AntBuildFileNodeDescriptor extends AntNodeDescriptor { if (buildModel != null) { AntTargetNodeDescriptor.addShortcutText(buildModel.getDefaultTargetActionId(), myAppearance); } - myIcon = AllIcons.Ant.Build; + setIcon(AllIcons.Ant.Build); myName = myBuildFile.getPresentableName(); return !Comparing.equal(myAppearance, oldAppearence); } diff --git a/plugins/ant/src/com/intellij/lang/ant/config/explorer/AntTargetNodeDescriptor.java b/plugins/ant/src/com/intellij/lang/ant/config/explorer/AntTargetNodeDescriptor.java index 044bd0f6028e..2b6671130582 100644 --- a/plugins/ant/src/com/intellij/lang/ant/config/explorer/AntTargetNodeDescriptor.java +++ b/plugins/ant/src/com/intellij/lang/ant/config/explorer/AntTargetNodeDescriptor.java @@ -66,7 +66,7 @@ final class AntTargetNodeDescriptor extends AntNodeDescriptor { final CompositeAppearance oldText = myHighlightedText; final boolean isMeta = myTarget instanceof MetaTarget; - myIcon = isMeta ? AllIcons.Ant.MetaTarget : AllIcons.Ant.Target; + setIcon(isMeta ? AllIcons.Ant.MetaTarget : AllIcons.Ant.Target); myHighlightedText = new CompositeAppearance(); diff --git a/plugins/gradle/src/org/jetbrains/plugins/gradle/ui/GradleProjectStructureNodeDescriptor.java b/plugins/gradle/src/org/jetbrains/plugins/gradle/ui/GradleProjectStructureNodeDescriptor.java index 9a9b1abda8d1..41762886d339 100644 --- a/plugins/gradle/src/org/jetbrains/plugins/gradle/ui/GradleProjectStructureNodeDescriptor.java +++ b/plugins/gradle/src/org/jetbrains/plugins/gradle/ui/GradleProjectStructureNodeDescriptor.java @@ -30,7 +30,7 @@ public class GradleProjectStructureNodeDescriptor exte public GradleProjectStructureNodeDescriptor(@NotNull T id, @NotNull String text, @Nullable Icon icon) { super(null, null); myId = id; - myIcon = icon; + setIcon(icon); myName = text; } @@ -38,7 +38,7 @@ public class GradleProjectStructureNodeDescriptor exte protected void update(@NotNull PresentationData presentation) { presentation.setAttributesKey(myAttributes); presentation.setPresentableText(myName); - presentation.setIcon(myIcon); + presentation.setIcon(getIcon()); } @NotNull diff --git a/plugins/ui-designer/ui-designer-new/src/com/intellij/designer/componentTree/TreeNodeDescriptor.java b/plugins/ui-designer/ui-designer-new/src/com/intellij/designer/componentTree/TreeNodeDescriptor.java index ec3cb7b9579d..28900e5806b1 100644 --- a/plugins/ui-designer/ui-designer-new/src/com/intellij/designer/componentTree/TreeNodeDescriptor.java +++ b/plugins/ui-designer/ui-designer-new/src/com/intellij/designer/componentTree/TreeNodeDescriptor.java @@ -18,8 +18,6 @@ package com.intellij.designer.componentTree; import com.intellij.ide.util.treeView.NodeDescriptor; import org.jetbrains.annotations.Nullable; -import javax.swing.*; - /** * @author Alexander Lobas */ @@ -45,8 +43,4 @@ public final class TreeNodeDescriptor extends NodeDescriptor { public Object getElement() { return myElement; } - - public void setIcon(Icon icon) { - myIcon = icon; - } } diff --git a/plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/associations/impl/AssociationsEditor.java b/plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/associations/impl/AssociationsEditor.java index 64b483f2afb9..170e78d8719f 100644 --- a/plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/associations/impl/AssociationsEditor.java +++ b/plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/associations/impl/AssociationsEditor.java @@ -387,7 +387,7 @@ class AssociationsEditor { public MyNodeDescriptor(NodeDescriptor nodeDescriptor) { super(nodeDescriptor.getProject(), null); myName = nodeDescriptor.toString(); - myIcon = LayeredIcon.create(nodeDescriptor.getIcon(), LINK_OVERLAY); + setIcon(LayeredIcon.create(nodeDescriptor.getIcon(), LINK_OVERLAY)); myColor = nodeDescriptor.getColor(); myNode = nodeDescriptor.getElement(); }