From b8dc92e38385a0c9e6b787aa254eb3ba60a27acd Mon Sep 17 00:00:00 2001
From: Peter Gromov <peter@jetbrains.com>
Date: Wed, 22 Jul 2020 15:54:45 +0200
Subject: [PATCH] fix for EA-234762 - CCE:
 StreamConversion.generateStreamSuggestions (IDEA-CR-65315)

GitOrigin-RevId: 7c04c7efa0523bfeeb7fa2932ec7e9535ca23425
---
 .../intellij/codeInsight/completion/StreamConversion.java  | 4 ----
 .../completion/normal/NoStreamSuggestionsOnBrokenCode.java | 7 +++++++
 .../codeInsight/completion/Normal8CompletionTest.groovy    | 2 ++
 3 files changed, 9 insertions(+), 4 deletions(-)
 create mode 100644 java/java-tests/testData/codeInsight/daemonCodeAnalyzer/lambda/completion/normal/NoStreamSuggestionsOnBrokenCode.java

diff --git a/java/java-impl/src/com/intellij/codeInsight/completion/StreamConversion.java b/java/java-impl/src/com/intellij/codeInsight/completion/StreamConversion.java
index afee1fcdd8a5..82a929902a96 100644
--- a/java/java-impl/src/com/intellij/codeInsight/completion/StreamConversion.java
+++ b/java/java-impl/src/com/intellij/codeInsight/completion/StreamConversion.java
@@ -5,8 +5,6 @@ import com.intellij.application.options.CodeStyle;
 import com.intellij.codeInsight.ExpectedTypeInfo;
 import com.intellij.codeInsight.ExpectedTypesProvider;
 import com.intellij.codeInsight.lookup.*;
-import com.intellij.openapi.diagnostic.Attachment;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.Pair;
 import com.intellij.openapi.util.TextRange;
@@ -31,7 +29,6 @@ import static com.intellij.psi.CommonClassNames.*;
  * @author peter
  */
 final class StreamConversion {
-  private static final Logger LOG = Logger.getInstance(StreamConversion.class);
 
   static List<LookupElement> addToStreamConversion(PsiReferenceExpression ref, CompletionParameters parameters) {
     PsiExpression qualifier = ref.getQualifierExpression();
@@ -74,7 +71,6 @@ final class StreamConversion {
     String refText = changedQualifier + ".x";
     PsiExpression expr = PsiElementFactory.getInstance(qualifier.getProject()).createExpressionFromText(refText, qualifier);
     if (!(expr instanceof PsiReferenceExpression)) {
-      LOG.error("Not a reference", new Attachment("reference.text", refText));
       return Collections.emptyList();
     }
 
diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/lambda/completion/normal/NoStreamSuggestionsOnBrokenCode.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/lambda/completion/normal/NoStreamSuggestionsOnBrokenCode.java
new file mode 100644
index 000000000000..0937437a511c
--- /dev/null
+++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/lambda/completion/normal/NoStreamSuggestionsOnBrokenCode.java
@@ -0,0 +1,7 @@
+class C {
+  String[] getArray() {return new String[0];}
+
+  void test() {
+    getArray(.map<caret>
+  }
+}
\ No newline at end of file
diff --git a/java/java-tests/testSrc/com/intellij/java/codeInsight/completion/Normal8CompletionTest.groovy b/java/java-tests/testSrc/com/intellij/java/codeInsight/completion/Normal8CompletionTest.groovy
index 12dc69747d7a..66404cba39f7 100644
--- a/java/java-tests/testSrc/com/intellij/java/codeInsight/completion/Normal8CompletionTest.groovy
+++ b/java/java-tests/testSrc/com/intellij/java/codeInsight/completion/Normal8CompletionTest.groovy
@@ -484,4 +484,6 @@ class Test88 {
     myFixture.assertPreferredCompletionItems 0, 'aDouble -> ', 'doubleValue'
   }
 
+  void testNoStreamSuggestionsOnBrokenCode() { doAntiTest() }
+
 }
\ No newline at end of file