From b7c8e98770790f77a93f9aa92e57505d60909a54 Mon Sep 17 00:00:00 2001 From: "Anna.Kozlova" Date: Tue, 6 Nov 2018 18:58:21 +0100 Subject: [PATCH] ensure inspection provides expected getShortName() used in tests --- .../RedundantStringOperationInspectionTest.java | 10 +--------- .../redundancy/RedundantStringOperationInspection.java | 6 ++++++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/java/java-tests/testSrc/com/intellij/java/codeInsight/daemon/quickFix/RedundantStringOperationInspectionTest.java b/java/java-tests/testSrc/com/intellij/java/codeInsight/daemon/quickFix/RedundantStringOperationInspectionTest.java index d701499c536f..526e6158e33f 100644 --- a/java/java-tests/testSrc/com/intellij/java/codeInsight/daemon/quickFix/RedundantStringOperationInspectionTest.java +++ b/java/java-tests/testSrc/com/intellij/java/codeInsight/daemon/quickFix/RedundantStringOperationInspectionTest.java @@ -2,24 +2,16 @@ package com.intellij.java.codeInsight.daemon.quickFix; import com.intellij.codeInsight.daemon.quickFix.LightQuickFixParameterizedTestCase; -import com.intellij.codeInspection.InspectionProfileEntry; import com.intellij.codeInspection.LocalInspectionTool; -import com.intellij.testFramework.InspectionTestUtil; import com.siyeh.ig.redundancy.RedundantStringOperationInspection; import org.jetbrains.annotations.NotNull; -import java.util.Collections; -import java.util.List; - public class RedundantStringOperationInspectionTest extends LightQuickFixParameterizedTestCase { @NotNull @Override protected LocalInspectionTool[] configureLocalInspectionTools() { - List tools = - InspectionTestUtil.instantiateTools(Collections.singleton(RedundantStringOperationInspection.class)); - - return new LocalInspectionTool[]{(LocalInspectionTool)tools.iterator().next()}; + return new LocalInspectionTool[]{new RedundantStringOperationInspection()}; } @Override diff --git a/plugins/InspectionGadgets/src/com/siyeh/ig/redundancy/RedundantStringOperationInspection.java b/plugins/InspectionGadgets/src/com/siyeh/ig/redundancy/RedundantStringOperationInspection.java index 199df02773cd..f50cf0352c48 100644 --- a/plugins/InspectionGadgets/src/com/siyeh/ig/redundancy/RedundantStringOperationInspection.java +++ b/plugins/InspectionGadgets/src/com/siyeh/ig/redundancy/RedundantStringOperationInspection.java @@ -57,6 +57,12 @@ public class RedundantStringOperationInspection extends AbstractBaseJavaLocalIns return InspectionGadgetsBundle.message("inspection.redundant.string.operation.display.name"); } + @NotNull + @Override + public String getShortName() { + return "StringOperationCanBeSimplified"; + } + @NotNull @Override public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {