From b73f7f9c7a77f57a5ba47c597799f538e1db3de4 Mon Sep 17 00:00:00 2001
From: Anna Kozlova <anna.kozlova@jetbrains.com>
Date: Mon, 9 Mar 2015 15:52:36 +0100
Subject: [PATCH] hide add import fix if qualified name of imported class is
 not a valid qName (IDEA-137296)

(cherry picked from commit bfae9cef8ff0d4fd773d6ee66f952b324d5e01ec)
---
 .../daemon/impl/quickfix/ImportClassFixBase.java  |  5 +++--
 .../intention/AddImportActionTest.groovy          | 15 +++++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ImportClassFixBase.java b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ImportClassFixBase.java
index c1aa8650f3cb..efc782949fdc 100644
--- a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ImportClassFixBase.java
+++ b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ImportClassFixBase.java
@@ -119,7 +119,8 @@ public abstract class ImportClassFixBase<T extends PsiElement, R extends PsiRefe
     }
 
     boolean referenceHasTypeParameters = hasTypeParameters(myRef);
-    PsiClass[] classes = PsiShortNamesCache.getInstance(myElement.getProject()).getClassesByName(name, scope);
+    final Project project = myElement.getProject();
+    PsiClass[] classes = PsiShortNamesCache.getInstance(project).getClassesByName(name, scope);
     if (classes.length == 0) return Collections.emptyList();
     List<PsiClass> classList = new ArrayList<PsiClass>(classes.length);
     boolean isAnnotationReference = myElement.getParent() instanceof PsiAnnotation;
@@ -130,7 +131,7 @@ public abstract class ImportClassFixBase<T extends PsiElement, R extends PsiRefe
       if (referenceHasTypeParameters && !aClass.hasTypeParameters()) continue;
       String qName = aClass.getQualifiedName();
       if (qName != null) { //filter local classes
-        if (qName.indexOf('.') == -1) continue; //do not show classes from default package)
+        if (qName.indexOf('.') == -1 || !PsiNameHelper.getInstance(project).isQualifiedName(qName)) continue; //do not show classes from default or invalid package
         if (qName.endsWith(name) && (file == null || ImportFilter.shouldImport(file, qName))) {
           if (isAccessible(aClass, myElement)) {
             classList.add(aClass);
diff --git a/java/java-tests/testSrc/com/intellij/codeInsight/intention/AddImportActionTest.groovy b/java/java-tests/testSrc/com/intellij/codeInsight/intention/AddImportActionTest.groovy
index 1c5000ce81ae..972cd368d4a9 100644
--- a/java/java-tests/testSrc/com/intellij/codeInsight/intention/AddImportActionTest.groovy
+++ b/java/java-tests/testSrc/com/intellij/codeInsight/intention/AddImportActionTest.groovy
@@ -278,6 +278,21 @@ class Test {
     assert !myFixture.filterAvailableIntentions("Import class")
   }
 
+  public void "test don't import class if qualified name is not valid"() {
+    myFixture.addClass('''
+package a..p;
+public class MMM {}
+''')
+    myFixture.configureByText 'a.java', '''
+class Test {
+    {
+      MM<caret>M m;
+    }
+}
+'''
+    assert !myFixture.filterAvailableIntentions("Import class")
+  }
+
   public void "test don't import class in assignment"() {
     myFixture.configureByText 'a.java', '''
 class Test {