From b6d66154409cc1ea77e5aad928e09e8118d8b595 Mon Sep 17 00:00:00 2001 From: Nadya Zabrodina Date: Fri, 4 Oct 2013 19:08:45 +0400 Subject: [PATCH] IDEA-114428 Clear-text Mercurial passwords in idea.log --- .../src/org/zmlx/hg4idea/execution/HgCommandExecutor.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/hg4idea/src/org/zmlx/hg4idea/execution/HgCommandExecutor.java b/plugins/hg4idea/src/org/zmlx/hg4idea/execution/HgCommandExecutor.java index 8d3fc2cd509b..ca3020f06cf0 100644 --- a/plugins/hg4idea/src/org/zmlx/hg4idea/execution/HgCommandExecutor.java +++ b/plugins/hg4idea/src/org/zmlx/hg4idea/execution/HgCommandExecutor.java @@ -239,8 +239,9 @@ public final class HgCommandExecutor { final int lastSlashIndex = settings.getHgExecutable().lastIndexOf(File.separator); exeName = settings.getHgExecutable().substring(lastSlashIndex + 1); - final String cmdString = String.format("%s %s %s", exeName, operation, arguments == null ? "" : StringUtil.join(arguments, " ")); - + String str = String.format("%s %s %s", exeName, operation, arguments == null ? "" : StringUtil.join(arguments, " ")); + //remove password from path before log + final String cmdString = myDestination != null ? HgUtil.removePasswordIfNeeded(str) : str; final boolean isUnitTestMode = ApplicationManager.getApplication().isUnitTestMode(); // log command if (isUnitTestMode) {