From b4544c7a42f4f88b9e569bc7a4b166a00d776b82 Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Tue, 4 Feb 2025 11:35:33 +0100 Subject: [PATCH] Java: clearer name for inspection and quick-fix GitOrigin-RevId: 0ee29991b00d4ac8341c031a4a111b23bb44b800 --- .../convert2Local/afterLocalClassMultipleMethods.java | 2 +- .../quickFix/convert2Local/afterMultipleMethods.java | 2 +- .../quickFix/convert2Local/afterOtherFieldInitilizer.java | 2 +- .../beforeInnerFieldReferencedFromOuterClass.java | 2 +- .../convert2Local/beforeLocalClassMultipleMethods.java | 2 +- .../quickFix/convert2Local/beforeMultipleMethods.java | 2 +- .../convert2Local/beforeMultipleMethodsOnReadOnly.java | 2 +- .../quickFix/convert2Local/beforeOtherFieldInitilizer.java | 2 +- .../quickFix/convert2Local/beforeUsedInJavadoc.java | 2 +- .../convert2Local/previewLocalClassMultipleMethods.java | 2 +- .../quickFix/convert2Local/previewMultipleMethods.java | 2 +- .../quickFix/convert2Local/previewOtherFieldInitilizer.java | 2 +- .../quickFix/ConvertParameterToLocalVariable/afterFor.java | 2 +- .../quickFix/ConvertParameterToLocalVariable/afterIf.java | 2 +- .../ConvertParameterToLocalVariable/afterJavadocRef.java | 2 +- .../quickFix/ConvertParameterToLocalVariable/afterSimple.java | 2 +- .../ConvertParameterToLocalVariable/afterUpdateCallers.java | 2 +- .../ConvertParameterToLocalVariable/afterUpdateCallers1.java | 2 +- .../quickFix/ConvertParameterToLocalVariable/beforeFor.java | 2 +- .../quickFix/ConvertParameterToLocalVariable/beforeIf.java | 2 +- .../ConvertParameterToLocalVariable/beforeJavadocRef.java | 2 +- .../ConvertParameterToLocalVariable/beforeOverriden.java | 2 +- .../ConvertParameterToLocalVariable/beforeSimple.java | 2 +- .../ConvertParameterToLocalVariable/beforeUpdateCallers.java | 2 +- .../ConvertParameterToLocalVariable/beforeUpdateCallers1.java | 2 +- java/openapi/resources/messages/JavaBundle.properties | 4 ++-- 26 files changed, 27 insertions(+), 27 deletions(-) diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterLocalClassMultipleMethods.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterLocalClassMultipleMethods.java index 391699ff4b28..1d1c2744d25d 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterLocalClassMultipleMethods.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterLocalClassMultipleMethods.java @@ -1,4 +1,4 @@ -// "Convert to local" "true-preview" +// "Convert to local variable" "true-preview" class Outer { void test() { diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterMultipleMethods.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterMultipleMethods.java index 80093e182f8c..348e76b02219 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterMultipleMethods.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterMultipleMethods.java @@ -1,4 +1,4 @@ -// "Convert to local" "true-preview" +// "Convert to local variable" "true-preview" class Test { int getFoo1() { diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterOtherFieldInitilizer.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterOtherFieldInitilizer.java index 81a3c01ca349..683121228426 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterOtherFieldInitilizer.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/afterOtherFieldInitilizer.java @@ -1,4 +1,4 @@ -// "Convert to local" "true-preview" +// "Convert to local variable" "true-preview" class Test { private Runnable r = () -> { diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeInnerFieldReferencedFromOuterClass.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeInnerFieldReferencedFromOuterClass.java index c671cc55713d..2bb41785e75d 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeInnerFieldReferencedFromOuterClass.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeInnerFieldReferencedFromOuterClass.java @@ -1,4 +1,4 @@ -// "Fix all 'Field can be local' problems in file" "false" +// "Fix all 'Field can be local variable' problems in file" "false" class Outer { void test(Inner inner) { diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeLocalClassMultipleMethods.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeLocalClassMultipleMethods.java index fec7cea64e6a..18d8dd2e241f 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeLocalClassMultipleMethods.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeLocalClassMultipleMethods.java @@ -1,4 +1,4 @@ -// "Convert to local" "true-preview" +// "Convert to local variable" "true-preview" class Outer { void test() { diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeMultipleMethods.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeMultipleMethods.java index 5d3bc3956645..30bb89a8567f 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeMultipleMethods.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeMultipleMethods.java @@ -1,4 +1,4 @@ -// "Convert to local" "true-preview" +// "Convert to local variable" "true-preview" class Test { private int myFoo; diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeMultipleMethodsOnReadOnly.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeMultipleMethodsOnReadOnly.java index 509aa695768e..ffebac6c7d04 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeMultipleMethodsOnReadOnly.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeMultipleMethodsOnReadOnly.java @@ -1,4 +1,4 @@ -// "Fix all 'Field can be local' problems in file" "false" +// "Fix all 'Field can be local variable' problems in file" "false" class MyClassTest { private boolean editable = false; diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeOtherFieldInitilizer.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeOtherFieldInitilizer.java index f0d8dc52ed8f..2a94933c3f8a 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeOtherFieldInitilizer.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeOtherFieldInitilizer.java @@ -1,4 +1,4 @@ -// "Convert to local" "true-preview" +// "Convert to local variable" "true-preview" class Test { private String field; diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeUsedInJavadoc.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeUsedInJavadoc.java index dbd56d5024bb..257dad1db23f 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeUsedInJavadoc.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/beforeUsedInJavadoc.java @@ -1,4 +1,4 @@ -// "Fix all 'Field can be local' problems in file" "false" +// "Fix all 'Field can be local variable' problems in file" "false" class TestFieldConversion { private static int someInt = 0; diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewLocalClassMultipleMethods.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewLocalClassMultipleMethods.java index 391699ff4b28..1d1c2744d25d 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewLocalClassMultipleMethods.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewLocalClassMultipleMethods.java @@ -1,4 +1,4 @@ -// "Convert to local" "true-preview" +// "Convert to local variable" "true-preview" class Outer { void test() { diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewMultipleMethods.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewMultipleMethods.java index 80093e182f8c..348e76b02219 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewMultipleMethods.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewMultipleMethods.java @@ -1,4 +1,4 @@ -// "Convert to local" "true-preview" +// "Convert to local variable" "true-preview" class Test { int getFoo1() { diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewOtherFieldInitilizer.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewOtherFieldInitilizer.java index 81a3c01ca349..683121228426 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewOtherFieldInitilizer.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convert2Local/previewOtherFieldInitilizer.java @@ -1,4 +1,4 @@ -// "Convert to local" "true-preview" +// "Convert to local variable" "true-preview" class Test { private Runnable r = () -> { diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterFor.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterFor.java index 86b345c1bf86..8e08414c4c5d 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterFor.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterFor.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { public Temp() { for (int i = 0; i < 10; i++) { diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterIf.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterIf.java index fb0ca96b9529..e6d8f7518700 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterIf.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterIf.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { public boolean flag; diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterJavadocRef.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterJavadocRef.java index dc54cd9d407c..ae8345683b6f 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterJavadocRef.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterJavadocRef.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { /** * diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterSimple.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterSimple.java index 0668130ddaaf..f692ff1cafbc 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterSimple.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterSimple.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { void test() { diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterUpdateCallers.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterUpdateCallers.java index 4588da0d0739..bbda71138d59 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterUpdateCallers.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterUpdateCallers.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { void foo() { diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterUpdateCallers1.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterUpdateCallers1.java index 134f176c0616..b9c031872b39 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterUpdateCallers1.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/afterUpdateCallers1.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { void foo(int k) { diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeFor.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeFor.java index 6296690218f9..598b23780897 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeFor.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeFor.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { public Temp(int p) { for (int i = 0; i < 10; i++) { diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeIf.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeIf.java index b6d5e3f0dca0..6dc3bb16c1ac 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeIf.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeIf.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { public boolean flag; diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeJavadocRef.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeJavadocRef.java index a419661955cf..bbd5b5ff6903 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeJavadocRef.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeJavadocRef.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { /** * @param x diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeOverriden.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeOverriden.java index 0c0d8e2d890e..0103db0dd301 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeOverriden.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeOverriden.java @@ -1,4 +1,4 @@ -// "Convert to local" "false" +// "Convert to local variable" "false" class A { void foo(int i) { i = 3; diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeSimple.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeSimple.java index 82ac31b566a0..cf03ce27246c 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeSimple.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeSimple.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { void test(int p) { diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeUpdateCallers.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeUpdateCallers.java index 65f123eb3122..441d50330569 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeUpdateCallers.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeUpdateCallers.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { void foo(int x) { diff --git a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeUpdateCallers1.java b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeUpdateCallers1.java index 5b85e973f048..e84b3737f8ca 100644 --- a/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeUpdateCallers1.java +++ b/java/java-tests/testData/inspection/quickFix/ConvertParameterToLocalVariable/beforeUpdateCallers1.java @@ -1,4 +1,4 @@ -// "Convert to local" "true" +// "Convert to local variable" "true" class Temp { void foo(int x, int k) { diff --git a/java/openapi/resources/messages/JavaBundle.properties b/java/openapi/resources/messages/JavaBundle.properties index 3e9e1fdd8d6c..05611bae0724 100644 --- a/java/openapi/resources/messages/JavaBundle.properties +++ b/java/openapi/resources/messages/JavaBundle.properties @@ -398,7 +398,7 @@ inspection.conditional.break.in.infinite.loop.description=Conditional break insi inspection.conditional.break.in.infinite.loop.no.conversion.with.do.while=Don't suggest to replace with 'do while' inspection.conditional.break.in.infinite.loop.allow.condition.fusion=Allow merging with existing loop condition inspection.conditional.break.in.infinite.loop.suggest.conversion.when.if.is.single.stmt.in.loop=Suggest conversion when 'if' is a single statement in loop -inspection.convert.to.local.quickfix=Convert to local +inspection.convert.to.local.quickfix=Convert to local variable inspection.data.flow.display.name=Nullability and data flow problems inspection.data.flow.optional.of.nullable.misuse.display.name=Use of Optional.ofNullable with null or not-null argument inspection.data.flow.constant.values.display.name=Constant values @@ -460,7 +460,7 @@ inspection.export.results.implicit.constructor=implicit constructor of inspection.export.results.overrides.library.methods=Overrides library methods inspection.export.results.package=package inspection.export.results.type.references=The following uses this type -inspection.field.can.be.local.display.name=Field can be local +inspection.field.can.be.local.display.name=Field can be local variable inspection.field.can.be.local.problem.descriptor=Field can be converted to a local variable inspection.field.can.be.local.quickfix.constructor=Convert field to local variable in constructor inspection.field.can.be.local.quickfix.initializer=Convert field to local variable in initializer section