From b19a626b1591fa4846d5ab4882e092a5d7cd441d Mon Sep 17 00:00:00 2001 From: Roman Shevchenko Date: Fri, 13 Feb 2026 18:48:34 +0100 Subject: [PATCH] cleanup [platform]: removing remaining implementations from `LegacyExternalProductResourceUrls` GitOrigin-RevId: 533a6d9eec64cf1cc437da48ec147c717419a041 --- platform/platform-api/api-dump.txt | 4 ++-- .../customization/ExternalProductResourceUrls.kt | 5 +++-- .../LegacyExternalProductResourceUrls.kt | 13 ++++--------- 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/platform/platform-api/api-dump.txt b/platform/platform-api/api-dump.txt index 41590a4fe815..ce1469cf65ef 100644 --- a/platform/platform-api/api-dump.txt +++ b/platform/platform-api/api-dump.txt @@ -5391,7 +5391,7 @@ com.intellij.openapi.wm.ext.LibrarySearchHelper - a:isLibraryExists(com.intellij.openapi.project.Project):Z com.intellij.platform.ide.customization.ExternalProductResourceUrls - sf:Companion:com.intellij.platform.ide.customization.ExternalProductResourceUrls$Companion -- a:computePatchUrl(com.intellij.openapi.util.BuildNumber,com.intellij.openapi.util.BuildNumber):com.intellij.util.Url +- computePatchUrl(com.intellij.openapi.util.BuildNumber,com.intellij.openapi.util.BuildNumber):com.intellij.util.Url - getBugReportUrl():kotlin.jvm.functions.Function1 - getDownloadPageUrl():com.intellij.util.Url - getFeedbackReporter():com.intellij.platform.ide.customization.FeedbackReporter @@ -5400,7 +5400,7 @@ com.intellij.platform.ide.customization.ExternalProductResourceUrls - s:getInstance():com.intellij.platform.ide.customization.ExternalProductResourceUrls - getKeyboardShortcutsPdfUrl():com.intellij.util.Url - getTechnicalSupportUrl():kotlin.jvm.functions.Function1 -- a:getUpdateMetadataUrl():com.intellij.util.Url +- getUpdateMetadataUrl():com.intellij.util.Url - getWhatIsNewPageUrl():com.intellij.util.Url - getYouTubeChannelUrl():com.intellij.util.Url f:com.intellij.platform.ide.customization.ExternalProductResourceUrls$Companion diff --git a/platform/platform-api/src/com/intellij/platform/ide/customization/ExternalProductResourceUrls.kt b/platform/platform-api/src/com/intellij/platform/ide/customization/ExternalProductResourceUrls.kt index 4c6b2eb81797..5dcfeaa65053 100644 --- a/platform/platform-api/src/com/intellij/platform/ide/customization/ExternalProductResourceUrls.kt +++ b/platform/platform-api/src/com/intellij/platform/ide/customization/ExternalProductResourceUrls.kt @@ -1,4 +1,4 @@ -// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. +// Copyright 2000-2026 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. package com.intellij.platform.ide.customization import com.intellij.openapi.application.ApplicationManager @@ -30,13 +30,14 @@ interface ExternalProductResourceUrls { * used by JetBrains IDEs as a reference. */ val updateMetadataUrl: Url? + get() = null /** * Returns URL which can be used to download a patch from build [from] to build [to]. * This function is called only if [the metadata][updateMetadataUrl] contains information about a patch for these versions, * and a user initiates update. */ - fun computePatchUrl(from: BuildNumber, to: BuildNumber): Url? + fun computePatchUrl(from: BuildNumber, to: BuildNumber): Url? = null /** * Returns a function which computes URL for bug reporting. diff --git a/platform/platform-impl/src/com/intellij/platform/ide/impl/customization/LegacyExternalProductResourceUrls.kt b/platform/platform-impl/src/com/intellij/platform/ide/impl/customization/LegacyExternalProductResourceUrls.kt index b94854d450eb..55121964eee5 100644 --- a/platform/platform-impl/src/com/intellij/platform/ide/impl/customization/LegacyExternalProductResourceUrls.kt +++ b/platform/platform-impl/src/com/intellij/platform/ide/impl/customization/LegacyExternalProductResourceUrls.kt @@ -1,24 +1,19 @@ -// Copyright 2000-2023 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. +// Copyright 2000-2026 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. package com.intellij.platform.ide.impl.customization import com.intellij.openapi.diagnostic.thisLogger -import com.intellij.openapi.util.BuildNumber import com.intellij.platform.ide.customization.ExternalProductResourceUrls -import com.intellij.util.Url import org.jetbrains.annotations.ApiStatus @ApiStatus.Internal -@Suppress("DEPRECATION") class LegacyExternalProductResourceUrls : ExternalProductResourceUrls { init { thisLogger().warn(""" - |The default implementation LegacyExternalProductResourceUrls is deprecated and will be removed in the future; + |The default implementation LegacyExternalProductResourceUrls is deprecated and will be removed in the future. |Provide your own implementation of ExternalProductResourceUrls using data which is currently stored in |ApplicationInfo.xml file and register it as the service override. |IDEs developed by JetBrains should use BaseJetBrainsExternalProductResourceUrls as a superclass for their implementation. - |""".trimMargin()) + |""".trimMargin() + ) } - - override val updateMetadataUrl: Url? = null - override fun computePatchUrl(from: BuildNumber, to: BuildNumber): Url? = null }