From b1702d5ab78beab2d558cb12dfd1372ce60f3702 Mon Sep 17 00:00:00 2001
From: Ivan Semenov <ivan.semenov@jetbrains.com>
Date: Fri, 27 Jul 2018 19:35:45 +0300
Subject: [PATCH] [git] Always forget passwords when authentication fails

---
 .../src/git4idea/commands/GitHttpGuiAuthenticator.java      | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/plugins/git4idea/src/git4idea/commands/GitHttpGuiAuthenticator.java b/plugins/git4idea/src/git4idea/commands/GitHttpGuiAuthenticator.java
index 848271b287d6..7dce3184bf94 100644
--- a/plugins/git4idea/src/git4idea/commands/GitHttpGuiAuthenticator.java
+++ b/plugins/git4idea/src/git4idea/commands/GitHttpGuiAuthenticator.java
@@ -374,9 +374,9 @@ class GitHttpGuiAuthenticator implements GitHttpAuthenticator {
         if (rememberedLogin == null) {
           return null;
         }
-        return (myData = getDataForUser(url, rememberedLogin));
+        return getDataForUser(url, rememberedLogin);
       }
-      return (myData = getDataForUser(url, login));
+      return getDataForUser(url, login);
     }
 
     @Override
@@ -385,7 +385,7 @@ class GitHttpGuiAuthenticator implements GitHttpAuthenticator {
       String key = makeKey(url, login);
       Credentials credentials = CredentialAttributesKt.getAndMigrateCredentials(oldCredentialAttributes(key), credentialAttributes(key));
       String password = StringUtil.nullize(credentials == null ? null : credentials.getPasswordAsString());
-      return new AuthData(login, password);
+      return (myData = new AuthData(login, password));
     }
 
     @Override