From b0d9f51d6a2f2309df7edc025e6380b80668d2a1 Mon Sep 17 00:00:00 2001 From: Peter Gromov Date: Wed, 1 Apr 2020 09:05:17 +0200 Subject: [PATCH] remove LookupImpl.clear which even Rider seems not to need (IDEA-CR-60922) GitOrigin-RevId: 162ea2d960fa6dd50d554f6133652318011745d8 --- .../codeInsight/completion/BaseCompletionLookupArranger.kt | 3 --- .../com/intellij/codeInsight/lookup/LookupArranger.java | 7 ------- .../com/intellij/codeInsight/lookup/impl/LookupImpl.java | 4 ---- 3 files changed, 14 deletions(-) diff --git a/platform/analysis-impl/src/com/intellij/codeInsight/completion/BaseCompletionLookupArranger.kt b/platform/analysis-impl/src/com/intellij/codeInsight/completion/BaseCompletionLookupArranger.kt index 1902a9d6ed02..83904d6644fc 100644 --- a/platform/analysis-impl/src/com/intellij/codeInsight/completion/BaseCompletionLookupArranger.kt +++ b/platform/analysis-impl/src/com/intellij/codeInsight/completion/BaseCompletionLookupArranger.kt @@ -165,9 +165,6 @@ open class BaseCompletionLookupArranger(@JvmField protected val myProcess: Compl trimToLimit(createContext()) } - @Synchronized - override fun clear() = super.clear() - @Synchronized override fun itemPattern(element: LookupElement): String = super.itemPattern(element) diff --git a/platform/analysis-impl/src/com/intellij/codeInsight/lookup/LookupArranger.java b/platform/analysis-impl/src/com/intellij/codeInsight/lookup/LookupArranger.java index e28ae4f03d7d..ac55bb391d1b 100644 --- a/platform/analysis-impl/src/com/intellij/codeInsight/lookup/LookupArranger.java +++ b/platform/analysis-impl/src/com/intellij/codeInsight/lookup/LookupArranger.java @@ -30,13 +30,6 @@ public abstract class LookupArranger implements WeighingContext { updateCache(item); } - public void clear() { - myItems.clear(); - myMatchingItems.clear(); - myExactPrefixItems.clear(); - myInexactPrefixItems.clear(); - } - private void updateCache(LookupElement item) { if (!prefixMatches(item)) { return; diff --git a/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/LookupImpl.java b/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/LookupImpl.java index f4f3ad9cfae4..50e5ed33508f 100644 --- a/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/LookupImpl.java +++ b/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/LookupImpl.java @@ -276,10 +276,6 @@ public class LookupImpl extends LightweightHint implements LookupEx, Disposable, return true; } - public void clear() { - myArranger.clear(); - } - private void addDummyItems(int count) { EmptyLookupItem dummy = new EmptyLookupItem("loading...", true); for (int i = count; i > 0; i--) {