From afb118bf6e2c4a6587a3f09ea7d0960ee8fccb37 Mon Sep 17 00:00:00 2001 From: peter Date: Tue, 23 Oct 2012 08:48:51 +0200 Subject: [PATCH] better groovyc logging --- .../jetbrains/jps/incremental/groovy/GroovyBuilder.java | 4 +++- .../jps/incremental/groovy/GroovycOSProcessHandler.java | 8 ++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/plugins/groovy/jps-plugin/src/org/jetbrains/jps/incremental/groovy/GroovyBuilder.java b/plugins/groovy/jps-plugin/src/org/jetbrains/jps/incremental/groovy/GroovyBuilder.java index 4ef2ddd39143..b7645ae3409e 100644 --- a/plugins/groovy/jps-plugin/src/org/jetbrains/jps/incremental/groovy/GroovyBuilder.java +++ b/plugins/groovy/jps-plugin/src/org/jetbrains/jps/incremental/groovy/GroovyBuilder.java @@ -76,7 +76,6 @@ public class GroovyBuilder extends ModuleLevelBuilder { } if (Utils.IS_TEST_MODE || LOG.isDebugEnabled()) { LOG.info("forStubs=" + myForStubs); - LOG.info("toCompile: " + toCompile); } Map finalOutputs = getCanonicalModuleOutputs(context, chunk); @@ -128,6 +127,9 @@ public class GroovyBuilder extends ModuleLevelBuilder { private static Set getPathsToCompile(List toCompile) { final Set toCompilePaths = new LinkedHashSet(); for (File file : toCompile) { + if (LOG.isDebugEnabled()) { + LOG.debug("Path to compile: " + file.getPath()); + } toCompilePaths.add(FileUtil.toSystemIndependentName(file.getPath())); } return toCompilePaths; diff --git a/plugins/groovy/jps-plugin/src/org/jetbrains/jps/incremental/groovy/GroovycOSProcessHandler.java b/plugins/groovy/jps-plugin/src/org/jetbrains/jps/incremental/groovy/GroovycOSProcessHandler.java index 0afaaad08a55..8eed8b51a54a 100644 --- a/plugins/groovy/jps-plugin/src/org/jetbrains/jps/incremental/groovy/GroovycOSProcessHandler.java +++ b/plugins/groovy/jps-plugin/src/org/jetbrains/jps/incremental/groovy/GroovycOSProcessHandler.java @@ -44,7 +44,7 @@ public class GroovycOSProcessHandler extends BaseOSProcessHandler { private final List compilerMessages = new ArrayList(); private final StringBuffer stdErr = new StringBuffer(); - private static final Logger LOG = Logger.getInstance("org.jetbrains.jps.incremental.groovy.GroovycOSProcessHandler"); + private static final Logger LOG = Logger.getInstance("#org.jetbrains.jps.incremental.groovy.GroovycOSProcessHandler"); private final Consumer myStatusUpdater; public GroovycOSProcessHandler(Process process, Consumer statusUpdater) { @@ -150,11 +150,7 @@ public class GroovycOSProcessHandler extends BaseOSProcessHandler { ? BuildMessage.Kind.WARNING : BuildMessage.Kind.INFO; - CompilerMessage msg = new CompilerMessage("Groovyc", kind, message, url, -1, -1, -1, lineInt, columnInt); - if (LOG.isDebugEnabled()) { - LOG.debug("Message received: " + msg); - } - compilerMessages.add(msg); + compilerMessages.add(new CompilerMessage("Groovyc", kind, message, url, -1, -1, -1, lineInt, columnInt)); } } }