From ad97258c09c0e277f41555e6941715884bb77bc9 Mon Sep 17 00:00:00 2001
From: Anna Kozlova <anna.kozlova@jetbrains.com>
Date: Tue, 18 Aug 2020 21:55:29 +0200
Subject: [PATCH] inspections i18n: add warning about non-localized groupName

GitOrigin-RevId: 9c0ac3afa44dbc626c0e3b9bced1a7492f942afc
---
 .../inspections/PluginXmlI18nInspection.java  | 23 ++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/plugins/devkit/devkit-core/src/inspections/PluginXmlI18nInspection.java b/plugins/devkit/devkit-core/src/inspections/PluginXmlI18nInspection.java
index 97485f969b51..c4398a360b13 100644
--- a/plugins/devkit/devkit-core/src/inspections/PluginXmlI18nInspection.java
+++ b/plugins/devkit/devkit-core/src/inspections/PluginXmlI18nInspection.java
@@ -78,13 +78,20 @@ public class PluginXmlI18nInspection extends DevKitPluginXmlInspectionBase {
       if (implementationClass == null || implementationClass.getStringValue() == null) {
         return;
       }
-      GenericAttributeValue displayNameAttr = getAttribute(element, "displayName");
-      if (displayNameAttr != null && displayNameAttr.getStringValue() != null) {
-        holder.createProblem(element, ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
-                             DevKitBundle.message("inspections.plugin.xml.i18n.inspection.tag.family.name"),
-                             null,
-                             new InspectionI18NQuickFix());
-      }
+      checkInspectionDisplayName(holder, element, "displayName", new InspectionI18NQuickFix());
+      checkInspectionDisplayName(holder, element, "groupName", null);
+      //checkInspectionDisplayName(holder, element, "groupPath", null);
+    }
+  }
+
+  private static void checkInspectionDisplayName(DomElementAnnotationHolder holder,
+                                                 DomElement element,
+                                                 String attributeName, InspectionI18NQuickFix fix) {
+    GenericAttributeValue displayNameAttr = getAttribute(element, attributeName);
+    if (displayNameAttr != null && displayNameAttr.getStringValue() != null) {
+      holder.createProblem(element, 
+                           ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
+                           DevKitBundle.message("inspections.plugin.xml.i18n.inspection.tag.family.name", attributeName), null, fix);
     }
   }
 
@@ -193,7 +200,7 @@ public class PluginXmlI18nInspection extends DevKitPluginXmlInspectionBase {
     @NotNull
     @Override
     public String getFamilyName() {
-      return DevKitBundle.message("inspections.plugin.xml.i18n.inspection.tag.family.name");
+      return DevKitBundle.message("inspections.plugin.xml.i18n.inspection.tag.family.name", "displayName");
     }
 
     @Override