From abc3b389c4474dd74a9c2d134a18480ee2660eca Mon Sep 17 00:00:00 2001 From: Alexey Kudravtsev Date: Wed, 12 Feb 2025 12:02:58 +0100 Subject: [PATCH] highlighting tests optimization: do not run highlighting pass if its results are going to be ignored in tests GitOrigin-RevId: c6926fef6c415e1ba257cb164bd4a5e0648bccf1 --- .../idea/highlighter/AbstractHighlightingPassBase.kt | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/plugins/kotlin/highlighting/highlighting-minimal/src/org/jetbrains/kotlin/idea/highlighter/AbstractHighlightingPassBase.kt b/plugins/kotlin/highlighting/highlighting-minimal/src/org/jetbrains/kotlin/idea/highlighter/AbstractHighlightingPassBase.kt index 2db68b5ea824..ed0a276f0f47 100644 --- a/plugins/kotlin/highlighting/highlighting-minimal/src/org/jetbrains/kotlin/idea/highlighter/AbstractHighlightingPassBase.kt +++ b/plugins/kotlin/highlighting/highlighting-minimal/src/org/jetbrains/kotlin/idea/highlighter/AbstractHighlightingPassBase.kt @@ -24,7 +24,12 @@ abstract class AbstractHighlightingPassBase( override fun doCollectInformation(progress: ProgressIndicator) { val holder = HighlightInfoHolder(file) - runAnnotatorWithContext(file, holder) + if (IGNORE_IN_TESTS) { + assert(ApplicationManager.getApplication().isUnitTestMode) + } + else { + runAnnotatorWithContext(file, holder) + } applyInformationInBackground(holder) } @@ -55,10 +60,6 @@ abstract class AbstractHighlightingPassBase( } private fun applyInformationInBackground(holder: HighlightInfoHolder) { - if (IGNORE_IN_TESTS) { - assert(ApplicationManager.getApplication().isUnitTestMode) - return - } val result:MutableList = ArrayList(holder.size()) for (i in 0 until holder.size()) { result.add(holder.get(i))