From aa0d78697bb5a0ba58c317e7461d4fb70c485349 Mon Sep 17 00:00:00 2001 From: peter Date: Wed, 24 Dec 2014 11:39:42 +0100 Subject: [PATCH] don't infer that simple getters are pure: currently it provides no value for the user --- .../com/intellij/codeInspection/dataFlow/PurityInference.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/PurityInference.java b/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/PurityInference.java index ee81e7c09fd3..c626a96f8222 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/PurityInference.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/PurityInference.java @@ -22,6 +22,7 @@ import com.intellij.psi.*; import com.intellij.psi.tree.IElementType; import com.intellij.psi.util.CachedValueProvider; import com.intellij.psi.util.CachedValuesManager; +import com.intellij.psi.util.PropertyUtil; import com.intellij.util.containers.ContainerUtil; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -37,7 +38,8 @@ public class PurityInference { if (!InferenceFromSourceUtil.shouldInferFromSource(method) || method.getReturnType() == PsiType.VOID || method.getBody() == null || - method.isConstructor()) { + method.isConstructor() || + PropertyUtil.isSimpleGetter(method)) { return false; }