From a8b9f797287e4a275afd0bbcc8870d3c121bc428 Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Sat, 6 Sep 2014 10:54:41 +0200 Subject: [PATCH] improve name and description of "Anonymous class may be a named 'static' inner class" inspection --- .../src/com/siyeh/InspectionGadgetsBundle.properties | 4 ++-- .../AnonymousInnerClassMayBeStatic.html | 10 ++++------ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/InspectionGadgetsBundle.properties b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/InspectionGadgetsBundle.properties index b8016c72338c..96e25fcd8d7a 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/InspectionGadgetsBundle.properties +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/InspectionGadgetsBundle.properties @@ -445,8 +445,8 @@ use.processbuilder.class.problem.descriptor=Use of #ref is non-port use.sun.classes.display.name=Use of sun.* classes use.sun.classes.problem.descriptor=Use of Sun-supplied class #ref is non-portable #loc abstract.class.with.only.one.direct.inheritor.display.name=Abstract class which has only one direct inheritor -anonymous.inner.may.be.named.static.inner.class.display.name=Anonymous inner class may be a named static inner class -anonymous.inner.may.be.named.static.inner.class.problem.descriptor=Anonymous inner class #ref may be a named static inner class #loc +anonymous.inner.may.be.named.static.inner.class.display.name=Anonymous class may be a named 'static' inner class +anonymous.inner.may.be.named.static.inner.class.problem.descriptor=Anonymous class #ref may be a named 'static' inner class #loc array.length.in.loop.condition.display.name=Array.length in loop condition array.length.in.loop.condition.problem.descriptor=Check of array #ref in loop condition #loc large.array.allocation.no.outofmemoryerror.display.name=Large array allocation with no OutOfMemoryError check diff --git a/plugins/InspectionGadgets/src/inspectionDescriptions/AnonymousInnerClassMayBeStatic.html b/plugins/InspectionGadgets/src/inspectionDescriptions/AnonymousInnerClassMayBeStatic.html index 9311966c365b..891ba6333e5e 100644 --- a/plugins/InspectionGadgets/src/inspectionDescriptions/AnonymousInnerClassMayBeStatic.html +++ b/plugins/InspectionGadgets/src/inspectionDescriptions/AnonymousInnerClassMayBeStatic.html @@ -1,11 +1,9 @@ -This inspection is intended for J2ME and other highly resource constrained environments. -Applying the results of this inspection without consideration might have negative effects on code clarity and design. -

-Reports any anonymous inner classes which may safely be made into a named -static inner class. An inner class may be static if it doesn't reference -its enclosing class instance or local variables. A static inner class uses slightly less memory. +Reports any anonymous classes which may safely be made into a named static inner class. +An anonymous class may be static if it doesn't explicitly reference its enclosing instance or local variables from its surrounding method. +A static inner class does not keep an implicit reference to its enclosing instance. +This prevents a common cause of memory leaks and uses less memory per instance of the class.