From a7ded60f986abb468b7d6ea714d0da7f9945d1ed Mon Sep 17 00:00:00 2001 From: Julia Beliaeva Date: Sat, 28 Apr 2018 18:33:56 +0300 Subject: [PATCH] [vcs-log] align diff preview toolbar with main toolbar, add side border --- .../src/com/intellij/diff/impl/DiffRequestProcessor.java | 6 ++++-- .../impl/src/com/intellij/vcs/log/ui/frame/MainFrame.java | 1 + .../intellij/vcs/log/ui/frame/VcsLogChangeProcessor.java | 8 ++++++++ 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/platform/diff-impl/src/com/intellij/diff/impl/DiffRequestProcessor.java b/platform/diff-impl/src/com/intellij/diff/impl/DiffRequestProcessor.java index 98375f9229fc..29f75ba627a9 100644 --- a/platform/diff-impl/src/com/intellij/diff/impl/DiffRequestProcessor.java +++ b/platform/diff-impl/src/com/intellij/diff/impl/DiffRequestProcessor.java @@ -97,8 +97,9 @@ public abstract class DiffRequestProcessor implements Disposable { @NotNull private final JPanel myPanel; @NotNull private final MyPanel myMainPanel; - @NotNull private final Wrapper myContentPanel; + @NotNull protected final Wrapper myContentPanel; @NotNull private final ActionToolbar myToolbar; + @NotNull protected final Wrapper myToolbarWrapper; @NotNull private final Wrapper myToolbarStatusPanel; @NotNull private final MyProgressBar myProgressBar; @@ -138,11 +139,12 @@ public abstract class DiffRequestProcessor implements Disposable { myToolbar = ActionManager.getInstance().createActionToolbar(ActionPlaces.DIFF_TOOLBAR, myToolbarGroup, true); myToolbar.setTargetComponent(myMainPanel); + myToolbarWrapper = new Wrapper(myToolbar.getComponent()); myPanel = JBUI.Panels.simplePanel(myMainPanel); JPanel statusPanel = JBUI.Panels.simplePanel(myToolbarStatusPanel).addToLeft(myProgressBar); - JPanel topPanel = JBUI.Panels.simplePanel(myToolbar.getComponent()).addToRight(statusPanel); + JPanel topPanel = JBUI.Panels.simplePanel(myToolbarWrapper).addToRight(statusPanel); Splitter bottomContentSplitter = new JBSplitter(true, "DiffRequestProcessor.BottomComponentSplitter", 0.8f); bottomContentSplitter.setFirstComponent(myContentPanel); diff --git a/platform/vcs-log/impl/src/com/intellij/vcs/log/ui/frame/MainFrame.java b/platform/vcs-log/impl/src/com/intellij/vcs/log/ui/frame/MainFrame.java index 4d25045ac5dd..723048b51b52 100644 --- a/platform/vcs-log/impl/src/com/intellij/vcs/log/ui/frame/MainFrame.java +++ b/platform/vcs-log/impl/src/com/intellij/vcs/log/ui/frame/MainFrame.java @@ -136,6 +136,7 @@ public class MainFrame extends JPanel implements DataProvider, Disposable { myTextFilter = myFilterUi.createTextFilter(); myToolbar = createActionsToolbar(); myChangesBrowser.setToolbarHeightReferent(myToolbar); + myPreviewDiff.getToolbarWrapper().setVerticalSizeReferent(myToolbar); JComponent toolbars = new JPanel(new BorderLayout()); toolbars.add(myToolbar, BorderLayout.NORTH); diff --git a/platform/vcs-log/impl/src/com/intellij/vcs/log/ui/frame/VcsLogChangeProcessor.java b/platform/vcs-log/impl/src/com/intellij/vcs/log/ui/frame/VcsLogChangeProcessor.java index ad0b02b7d270..c8b87cbf8c8f 100644 --- a/platform/vcs-log/impl/src/com/intellij/vcs/log/ui/frame/VcsLogChangeProcessor.java +++ b/platform/vcs-log/impl/src/com/intellij/vcs/log/ui/frame/VcsLogChangeProcessor.java @@ -9,6 +9,8 @@ import com.intellij.openapi.util.Disposer; import com.intellij.openapi.vcs.changes.Change; import com.intellij.openapi.vcs.changes.ChangeViewDiffRequestProcessor; import com.intellij.openapi.vcs.changes.ui.ChangesTree; +import com.intellij.ui.IdeBorderFactory; +import com.intellij.ui.SideBorder; import com.intellij.util.containers.ContainerUtil; import com.intellij.util.ui.tree.TreeUtil; import org.jetbrains.annotations.NotNull; @@ -24,9 +26,15 @@ class VcsLogChangeProcessor extends ChangeViewDiffRequestProcessor { public VcsLogChangeProcessor(@NotNull Project project, @NotNull VcsLogChangesBrowser browser, @NotNull Disposable disposable) { super(project, DiffPlaces.VCS_LOG_VIEW); myBrowser = browser; + myContentPanel.setBorder(IdeBorderFactory.createBorder(SideBorder.TOP)); Disposer.register(disposable, this); } + @NotNull + public com.intellij.ui.components.panels.Wrapper getToolbarWrapper() { + return myToolbarWrapper; + } + @NotNull @Override protected List getSelectedChanges() {