From a796e2db2c7532c5f94d25feead52ced623e83f4 Mon Sep 17 00:00:00 2001 From: Vladimir Lagunov Date: Fri, 14 Jun 2024 16:19:51 +0200 Subject: [PATCH] IJPL-797 `intellij.platform.ide.util.io` review internal API: `ProcessService` and `WinProcessTerminator` are internal The class was created to reuse existing code in different products inside the company. It hasn't been supposed to be used by third-party plugins. No external usages were found. The same applies to `WinProcessTerminator`, which uses `ProcessService`. GitOrigin-RevId: 45b764ca47222ae71fd71b7a44f3a649f2dcc15a --- .../platform-util-io-impl/api-dump-unreviewed.txt | 1 - platform/platform-util-io/api-dump-unreviewed.txt | 14 -------------- .../intellij/execution/process/ProcessService.java | 4 +++- .../execution/process/WinProcessTerminator.kt | 4 +++- 4 files changed, 6 insertions(+), 17 deletions(-) diff --git a/platform/platform-util-io-impl/api-dump-unreviewed.txt b/platform/platform-util-io-impl/api-dump-unreviewed.txt index d424364bd48c..3f562812a2e9 100644 --- a/platform/platform-util-io-impl/api-dump-unreviewed.txt +++ b/platform/platform-util-io-impl/api-dump-unreviewed.txt @@ -1,5 +1,4 @@ f:com.intellij.execution.process.ProcessServiceImpl -- com.intellij.execution.process.ProcessService - ():V - getCommand(java.lang.Process):java.util.List - hasControllingTerminal(java.lang.Process):Z diff --git a/platform/platform-util-io/api-dump-unreviewed.txt b/platform/platform-util-io/api-dump-unreviewed.txt index 901365b703a6..37b4515fd679 100644 --- a/platform/platform-util-io/api-dump-unreviewed.txt +++ b/platform/platform-util-io/api-dump-unreviewed.txt @@ -381,18 +381,6 @@ c:com.intellij.execution.process.ProcessOutput - setCancelled():V - setExitCode(I):V - setTimeout():V -com.intellij.execution.process.ProcessService -- getCommand(java.lang.Process):java.util.List -- s:getInstance():com.intellij.execution.process.ProcessService -- a:hasControllingTerminal(java.lang.Process):Z -- a:isLocalPtyProcess(java.lang.Process):Z -- a:killWinProcess(I):V -- a:killWinProcessRecursively(java.lang.Process):V -- a:sendWinProcessCtrlC(I):Z -- a:sendWinProcessCtrlC(I,java.io.OutputStream):Z -- a:sendWinProcessCtrlC(java.lang.Process):Z -- a:startPtyProcess(java.lang.String[],java.lang.String,java.util.Map,com.intellij.execution.process.LocalPtyOptions,com.intellij.openapi.application.Application,Z,Z,Z):java.lang.Process -- a:winPtyChildProcessId(java.lang.Process):java.lang.Integer com.intellij.execution.process.ProcessTreeKiller - a:killProcessTree():Z c:com.intellij.execution.process.ProcessWrapper @@ -450,8 +438,6 @@ f:com.intellij.execution.process.SynchronizedProcessOutput - setCancelled():V - setExitCode(I):V - setTimeout():V -f:com.intellij.execution.process.WinProcessTerminator -- sf:terminateWinProcessGracefully(com.intellij.execution.process.KillableProcessHandler,com.intellij.execution.process.ProcessService):Z f:com.intellij.execution.process.WinRunnerMediator - s:withExternalConsole(com.intellij.execution.configurations.GeneralCommandLine):V f:com.intellij.execution.process.impl.ProcessListUtil diff --git a/platform/platform-util-io/src/com/intellij/execution/process/ProcessService.java b/platform/platform-util-io/src/com/intellij/execution/process/ProcessService.java index fce017e86dfe..017fd8ed053b 100644 --- a/platform/platform-util-io/src/com/intellij/execution/process/ProcessService.java +++ b/platform/platform-util-io/src/com/intellij/execution/process/ProcessService.java @@ -1,8 +1,9 @@ -// Copyright 2000-2021 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file. +// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. package com.intellij.execution.process; import com.intellij.openapi.application.Application; import com.intellij.openapi.application.ApplicationManager; +import org.jetbrains.annotations.ApiStatus; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -10,6 +11,7 @@ import java.io.OutputStream; import java.util.List; import java.util.Map; +@ApiStatus.Internal public interface ProcessService { @NotNull Process startPtyProcess(String @NotNull [] command, diff --git a/platform/platform-util-io/src/com/intellij/execution/process/WinProcessTerminator.kt b/platform/platform-util-io/src/com/intellij/execution/process/WinProcessTerminator.kt index 6f8629569333..d790b890c8f8 100644 --- a/platform/platform-util-io/src/com/intellij/execution/process/WinProcessTerminator.kt +++ b/platform/platform-util-io/src/com/intellij/execution/process/WinProcessTerminator.kt @@ -1,11 +1,13 @@ -// Copyright 2000-2021 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file. +// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. @file:JvmName("WinProcessTerminator") +@file:Internal package com.intellij.execution.process import com.intellij.openapi.application.ApplicationManager import com.intellij.openapi.diagnostic.logger import com.intellij.openapi.util.Key +import org.jetbrains.annotations.ApiStatus.Internal import java.util.concurrent.CompletableFuture import java.util.concurrent.TimeUnit