From a72ce2ab17b191b48a45c465ba0cff4f70a06d1f Mon Sep 17 00:00:00 2001
From: "Anna.Kozlova" <anna.kozlova@jetbrains.com>
Date: Mon, 6 Feb 2017 17:41:47 +0100
Subject: [PATCH] can be final: don't suggest final if field was not
 initialized (IDEA-167670)

---
 .../codeInspection/canBeFinal/CanBeFinalInspection.java  | 1 +
 .../canBeFinal/fieldImplicitWrite/expected.xml           | 9 +--------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/canBeFinal/CanBeFinalInspection.java b/java/java-analysis-impl/src/com/intellij/codeInspection/canBeFinal/CanBeFinalInspection.java
index 80109a54f4a7..b4aa6c0f0f11 100644
--- a/java/java-analysis-impl/src/com/intellij/codeInspection/canBeFinal/CanBeFinalInspection.java
+++ b/java/java-analysis-impl/src/com/intellij/codeInspection/canBeFinal/CanBeFinalInspection.java
@@ -161,6 +161,7 @@ public class CanBeFinalInspection extends GlobalJavaBatchInspectionTool {
         psiIdentifier = ((PsiMethod)psiMember).getNameIdentifier();
       }
       else if (refElement instanceof RefField) {
+        if (!((RefField)refElement).isUsedForWriting()) return null;
         if (!isReportFields()) return null;
         psiIdentifier = ((PsiField)psiMember).getNameIdentifier();
       }
diff --git a/java/java-tests/testData/inspection/canBeFinal/fieldImplicitWrite/expected.xml b/java/java-tests/testData/inspection/canBeFinal/fieldImplicitWrite/expected.xml
index 93b56fb7e0e4..4704d91e891d 100644
--- a/java/java-tests/testData/inspection/canBeFinal/fieldImplicitWrite/expected.xml
+++ b/java/java-tests/testData/inspection/canBeFinal/fieldImplicitWrite/expected.xml
@@ -1,9 +1,2 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<problems>
-  <problem>
-    <file>Test.java</file>
-    <line>3</line>
-    <description>Declaration can have final modifier</description>
-  </problem>
-
-</problems>
\ No newline at end of file
+<problems/>
\ No newline at end of file