From a4e4356f7cb3bba4d4f99e6e8b305b41e6bc1ac0 Mon Sep 17 00:00:00 2001 From: Konstantin Aleev Date: Fri, 31 Mar 2017 15:22:22 +0300 Subject: [PATCH] FinderRecursivePanel: reorder methods --- .../com/intellij/ui/FinderRecursivePanel.java | 34 ++++++++++--------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/platform/platform-impl/src/com/intellij/ui/FinderRecursivePanel.java b/platform/platform-impl/src/com/intellij/ui/FinderRecursivePanel.java index 49bedf73067a..a775244f5f4f 100644 --- a/platform/platform-impl/src/com/intellij/ui/FinderRecursivePanel.java +++ b/platform/platform-impl/src/com/intellij/ui/FinderRecursivePanel.java @@ -156,6 +156,22 @@ public abstract class FinderRecursivePanel extends OnePixelSplitter implement return null; } + /** + * Returns tooltip text for the given list item or null if no tooltip is available. + * + *

This method is invoked by panel's list cell render in order to set a tooltip text for the list cell render component. + * It is invoked before {@link #doCustomizeCellRenderer(SimpleColoredComponent, JList, Object, int, boolean, boolean)}, + * thus the tooltip may still be reset in {@code doCustomizeCellRenderer}. + * + * @param t the list item + * @return the text to display in a tooltip for the given list item + * @since 2017.2 + */ + @Nullable + protected String getItemTooltipText(T t) { + return null; + } + protected abstract boolean hasChildren(T t); /** @@ -341,7 +357,7 @@ public abstract class FinderRecursivePanel extends OnePixelSplitter implement try { setIcon(getItemIcon(t)); append(getItemText(t)); - this.setToolTipText(getItemTooltipText(t)); + setToolTipText(getItemTooltipText(t)); } catch (IndexNotReadyException e) { append("loading..."); @@ -375,7 +391,7 @@ public abstract class FinderRecursivePanel extends OnePixelSplitter implement : AllIcons.Icons.Ide.NextStepGrayed); result.add(this, BorderLayout.CENTER); result.add(childrenLabel, BorderLayout.EAST); - result.setToolTipText(this.getToolTipText()); + result.setToolTipText(getToolTipText()); return result; } return this; @@ -390,20 +406,6 @@ public abstract class FinderRecursivePanel extends OnePixelSplitter implement protected void doCustomizeCellRenderer(SimpleColoredComponent comp, JList list, T value, int index, boolean selected, boolean hasFocus) { } - /** - * This method is invoked by panel's list cell render in order to set a tool tip text for the list cell render component. - * It is invoked before {@link #doCustomizeCellRenderer(SimpleColoredComponent, JList, Object, int, boolean, boolean)}, - * thus the tool tip may still be reset in {@link #doCustomizeCellRenderer(SimpleColoredComponent, JList, Object, int, boolean, boolean)}. - * - * @param t the list item - * @return the text to display in a tool tip for the given list item - * @since 2017.2 - */ - @Nullable - protected String getItemTooltipText(T t) { - return null; - } - @Nullable @Override public Object getData(@NonNls String dataId) {