diff --git a/platform/dvcs-impl/src/com/intellij/dvcs/ui/BranchActionUtil.java b/platform/dvcs-impl/src/com/intellij/dvcs/ui/BranchActionUtil.java index 20be1cc9c0b2..92078bc3874f 100644 --- a/platform/dvcs-impl/src/com/intellij/dvcs/ui/BranchActionUtil.java +++ b/platform/dvcs-impl/src/com/intellij/dvcs/ui/BranchActionUtil.java @@ -15,16 +15,16 @@ */ package com.intellij.dvcs.ui; +import com.intellij.util.containers.ContainerUtil; + import java.util.Comparator; import java.util.List; public class BranchActionUtil { - public static final Comparator FAVOURITE_BRANCH_COMPARATOR = (o1, o2) -> { - if (o1.isFavourite() ^ o2.isFavourite()) return o1.isFavourite() ? -1 : 1; - return 0; - }; + public static final Comparator FAVOURITE_BRANCH_COMPARATOR = + Comparator.comparing(branch -> branch.isFavourite() ? -1 : 0); public static int getNumOfFavourites(List branchActions) { - return (int)branchActions.stream().filter(BranchActionGroup::isFavourite).count(); + return ContainerUtil.count(branchActions, BranchActionGroup::isFavourite); } } diff --git a/plugins/git4idea/src/git4idea/config/GitVcsSettings.java b/plugins/git4idea/src/git4idea/config/GitVcsSettings.java index 2db8117aad56..caa553e91bd9 100644 --- a/plugins/git4idea/src/git4idea/config/GitVcsSettings.java +++ b/plugins/git4idea/src/git4idea/config/GitVcsSettings.java @@ -91,6 +91,8 @@ public class GitVcsSettings implements PersistentStateComponent constructDefaultBranchPredefinedList(GitBranchType type) { - List branchInfos = myRepositoryManager.getRepositories().stream() - .map(repository -> new DvcsBranchInfo(repository.getRoot().getPath(), getDefaultBranchName(type))) - .collect(toList()); - branchInfos.add(new DvcsBranchInfo("", getDefaultBranchName(type))); + List branchInfos = newArrayList(new DvcsBranchInfo("", getDefaultBranchName(type))); + branchInfos.addAll(map2List(myRepositoryManager.getRepositories(), + repository -> new DvcsBranchInfo(repository.getRoot().getPath(), getDefaultBranchName(type)))); return branchInfos; } @@ -59,7 +59,7 @@ public class GitBranchManager { public boolean isFavourite(@NotNull GitBranchType branchType, @Nullable GitRepository repository, @NotNull String branchName) { if (mySettings.isFavourite(branchType, repository, branchName)) return true; - //if (mySettings.isExcludedFromFavourites(branchType, repository, branchName)) return false; + if (mySettings.isExcludedFromFavourites(branchType, repository, branchName)) return false; return myPredefinedFavouriteBranches.contains(branchType.toString(), repository, branchName); } @@ -69,14 +69,14 @@ public class GitBranchManager { boolean shouldBeFavourite) { if (shouldBeFavourite) { mySettings.addToFavourites(branchType, repository, branchName); - //mySettings.removeFromExcluded(branchType, repository, branchName); + mySettings.removeFromExcluded(branchType, repository, branchName); } else { if (mySettings.isFavourite(branchType, repository, branchName)) { mySettings.removeFromFavourites(branchType, repository, branchName); } else if (myPredefinedFavouriteBranches.contains(branchType.toString(), repository, branchName)) { - //mySettings.excludedFromFavourites() + mySettings.excludedFromFavourites(branchType, repository, branchName); } } }