From a2b3a8380a948ea82b71473dff97c39252972f12 Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Thu, 15 Jan 2015 14:44:09 +0100 Subject: [PATCH] "'clone()' instantiates objects with constructor" should warn on non-Cloneable class --- .../siyeh/ig/cloneable/CloneCallsConstructorsInspection.java | 2 +- .../clone_calls_constructors/CloneCallsConstructors.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/cloneable/CloneCallsConstructorsInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/cloneable/CloneCallsConstructorsInspection.java index 3cafe5dcfabd..2854cce8da7a 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/cloneable/CloneCallsConstructorsInspection.java +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/cloneable/CloneCallsConstructorsInspection.java @@ -53,7 +53,7 @@ public class CloneCallsConstructorsInspection extends BaseInspection { return; } final PsiClass aClass = method.getContainingClass(); - if (aClass == null || aClass.hasModifierProperty(PsiModifier.FINAL) || !CloneUtils.isCloneable(aClass)) { + if (aClass == null || aClass.hasModifierProperty(PsiModifier.FINAL)) { return; } method.accept(new JavaRecursiveElementVisitor() { diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/cloneable/clone_calls_constructors/CloneCallsConstructors.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/cloneable/clone_calls_constructors/CloneCallsConstructors.java index ec7fa278e29b..d42bc71b643e 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/cloneable/clone_calls_constructors/CloneCallsConstructors.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/cloneable/clone_calls_constructors/CloneCallsConstructors.java @@ -10,7 +10,7 @@ class CloneCallsConstructors implements Cloneable { class One { @Override public Object clone() throws CloneNotSupportedException { - return new One(); + return new One(); } } final class Two implements Cloneable {