diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/unusedImport/ImportsAreUsedVisitor.java b/java/java-analysis-impl/src/com/intellij/codeInspection/unusedImport/ImportsAreUsedVisitor.java index 7afd1d52d1bd..6d4909058269 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/unusedImport/ImportsAreUsedVisitor.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/unusedImport/ImportsAreUsedVisitor.java @@ -32,7 +32,7 @@ class ImportsAreUsedVisitor extends JavaRecursiveElementWalkingVisitor { private final List importStatements; private final List usedImportStatements = new ArrayList<>(); - ImportsAreUsedVisitor(PsiJavaFile file) { + ImportsAreUsedVisitor(@NotNull PsiJavaFile file) { myFile = file; final PsiImportList importList = file.getImportList(); if (importList == null) { @@ -91,25 +91,25 @@ class ImportsAreUsedVisitor extends JavaRecursiveElementWalkingVisitor { } } - private PsiImportStatementBase findImport(PsiMember member, List importStatements) { - final String qualifiedName; - final String packageName; + private PsiImportStatementBase findImport(@NotNull PsiMember member, List importStatements) { + final String memberQualifiedName; + final String memberPackageName; final PsiClass containingClass = member.getContainingClass(); if (member instanceof PsiClass referencedClass) { - qualifiedName = referencedClass.getQualifiedName(); - packageName = qualifiedName != null ? StringUtil.getPackageName(qualifiedName) : null; + memberQualifiedName = referencedClass.getQualifiedName(); + memberPackageName = memberQualifiedName != null ? StringUtil.getPackageName(memberQualifiedName) : null; } else { if (!member.hasModifierProperty(PsiModifier.STATIC) || containingClass == null) { return null; } - packageName = containingClass.getQualifiedName(); - qualifiedName = packageName + '.' + member.getName(); + memberPackageName = containingClass.getQualifiedName(); + memberQualifiedName = memberPackageName + '.' + member.getName(); } - if (packageName == null) { + if (memberPackageName == null) { return null; } - final boolean hasOnDemandImportConflict = ImportUtils.hasOnDemandImportConflict(qualifiedName, myFile); + final boolean hasOnDemandImportConflict = ImportUtils.hasOnDemandImportConflict(memberQualifiedName, myFile); for (PsiImportStatementBase importStatement : importStatements) { if (!importStatement.isOnDemand()) { final PsiJavaCodeReferenceElement reference = importStatement.getImportReference(); @@ -129,7 +129,7 @@ class ImportsAreUsedVisitor extends JavaRecursiveElementWalkingVisitor { } final PsiElement target = importStatement.resolve(); if (target instanceof PsiPackage aPackage) { - if (packageName.equals(aPackage.getQualifiedName())) { + if (memberPackageName.equals(aPackage.getQualifiedName())) { return importStatement; } } diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/unusedImport/UnusedImportInspection.java b/java/java-analysis-impl/src/com/intellij/codeInspection/unusedImport/UnusedImportInspection.java index 5fee5d71968d..dadcf22b16f3 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/unusedImport/UnusedImportInspection.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/unusedImport/UnusedImportInspection.java @@ -62,6 +62,7 @@ public class UnusedImportInspection extends GlobalSimpleInspectionTool { return false; } + @NotNull public static @Nls String getDisplayNameText() { return JavaAnalysisBundle.message("unused.import.display.name"); } diff --git a/platform/core-api/src/com/intellij/lang/Language.java b/platform/core-api/src/com/intellij/lang/Language.java index 66b33b34c443..0806fbe9db26 100644 --- a/platform/core-api/src/com/intellij/lang/Language.java +++ b/platform/core-api/src/com/intellij/lang/Language.java @@ -44,7 +44,7 @@ public abstract class Language extends UserDataHolderBase { public static final Language[] EMPTY_ARRAY = new Language[0]; private static final Object staticLock = new Object(); - private static volatile PersistentMap, Language> registeredLanguages = persistentHashMapOf(); + private static volatile PersistentMap, @NotNull Language> registeredLanguages = persistentHashMapOf(); private static volatile PersistentMap> registeredMimeTypes = persistentHashMapOf(); private static volatile PersistentMap registeredIds = persistentHashMapOf();