From a1c859de11954f285a8ea3d98b24bb0f551d9d5f Mon Sep 17 00:00:00 2001 From: Artem Khvastunov Date: Mon, 4 Jun 2018 14:44:09 +0200 Subject: [PATCH] add constructor to RenameElementFix which accepts quick fix text It happens that a sub class overrides RenameElementFix#getText(). In such a case RenameElementFix#myText is useless but nevertheless calculated and consumes memory. The commit is intended to fix this by adding a new constructor argument. --- .../impl/quickfix/RenameElementFix.java | 22 +++++-------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/RenameElementFix.java b/platform/lang-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/RenameElementFix.java index b685693f3fcc..c2917c2f36fb 100644 --- a/platform/lang-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/RenameElementFix.java +++ b/platform/lang-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/RenameElementFix.java @@ -1,18 +1,4 @@ -/* - * Copyright 2000-2017 JetBrains s.r.o. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ +// Copyright 2000-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file. package com.intellij.codeInsight.daemon.impl.quickfix; import com.intellij.codeInsight.CodeInsightBundle; @@ -48,9 +34,13 @@ public class RenameElementFix extends LocalQuickFixAndIntentionActionOnPsiElemen } public RenameElementFix(@NotNull PsiNamedElement element, @NotNull String newName) { + this(element, newName, CodeInsightBundle.message("rename.named.element.text", element.getName(), newName)); + } + + public RenameElementFix(@NotNull PsiNamedElement element, @NotNull String newName, @NotNull String text) { super(element); myNewName = newName; - myText = CodeInsightBundle.message("rename.named.element.text", element.getName(), myNewName); + myText = text; } @Override