From a00017c38e7c85ba9d3c4bb4da06589be32474ad Mon Sep 17 00:00:00 2001 From: Leonid Shalupov Date: Wed, 11 Feb 2026 02:12:08 +0100 Subject: [PATCH] MRI-2340 non-nls overrides non-nls constants were initially present in .form files, but became zero-tolerance warnings only after generating sources from .form GitOrigin-RevId: 2144db82237102cd132689a0de3ac42c0df9de5a --- .../impl/ui/properties/ElementWithManifestPropertiesPanel.java | 1 + .../execution/testframework/export/ExportTestResultsForm.java | 1 + plugins/dev/intellij.dev.psiViewer/src/PsiViewerDialog.java | 1 + .../extractFunction/ui/KotlinExtractFunctionDialog.java | 1 + .../extractFunction/ui/KotlinFirExtractFunctionDialog.java | 1 + .../plushnikov/intellij/plugin/settings/ProjectSettingsPage.java | 1 + .../src/com/intellij/tasks/generic/GenericRepositoryEditor.java | 1 + .../python/documentation/PythonDocumentationEntryEditor.java | 1 + .../refactoring/introduce/field/PyIntroduceFieldPanel.java | 1 + .../src/com/intellij/application/options/CodeStyleXmlPanel.java | 1 + 10 files changed, 10 insertions(+) diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/ui/properties/ElementWithManifestPropertiesPanel.java b/java/compiler/impl/src/com/intellij/packaging/impl/ui/properties/ElementWithManifestPropertiesPanel.java index 57b4b7fb10a6..67e0fa135b3b 100644 --- a/java/compiler/impl/src/com/intellij/packaging/impl/ui/properties/ElementWithManifestPropertiesPanel.java +++ b/java/compiler/impl/src/com/intellij/packaging/impl/ui/properties/ElementWithManifestPropertiesPanel.java @@ -52,6 +52,7 @@ public abstract class ElementWithManifestPropertiesPanel myEventDispatcher = EventDispatcher.create(ChangeListener.class); + @SuppressWarnings("HardCodedStringLiteral") public ExportTestResultsForm(ExportTestResultsConfiguration config, String defaultFileName, @NlsSafe String defaultFolder) { { // GUI initializer generated by IntelliJ IDEA GUI Designer diff --git a/plugins/dev/intellij.dev.psiViewer/src/PsiViewerDialog.java b/plugins/dev/intellij.dev.psiViewer/src/PsiViewerDialog.java index 2f36a1e91f12..ca954fd742d8 100644 --- a/plugins/dev/intellij.dev.psiViewer/src/PsiViewerDialog.java +++ b/plugins/dev/intellij.dev.psiViewer/src/PsiViewerDialog.java @@ -254,6 +254,7 @@ public class PsiViewerDialog extends DialogWrapper implements UiDataProvider { } } + @SuppressWarnings("HardCodedStringLiteral") public PsiViewerDialog(@NotNull Project project, @Nullable Editor selectedEditor) { super(project, true, IdeModalityType.MODELESS); { diff --git a/plugins/kotlin/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractFunction/ui/KotlinExtractFunctionDialog.java b/plugins/kotlin/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractFunction/ui/KotlinExtractFunctionDialog.java index f26d66a48b6f..d248c2de0156 100644 --- a/plugins/kotlin/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractFunction/ui/KotlinExtractFunctionDialog.java +++ b/plugins/kotlin/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractFunction/ui/KotlinExtractFunctionDialog.java @@ -81,6 +81,7 @@ public class KotlinExtractFunctionDialog extends DialogWrapper { private final Function1 onAccept; + @SuppressWarnings("HardCodedStringLiteral") public KotlinExtractFunctionDialog( @NotNull Project project, @NotNull ExtractableCodeDescriptorWithConflicts originalDescriptor, diff --git a/plugins/kotlin/refactorings/kotlin.refactorings.k2/src/org/jetbrains/kotlin/idea/k2/refactoring/extractFunction/ui/KotlinFirExtractFunctionDialog.java b/plugins/kotlin/refactorings/kotlin.refactorings.k2/src/org/jetbrains/kotlin/idea/k2/refactoring/extractFunction/ui/KotlinFirExtractFunctionDialog.java index 0ffaf17fa07a..b1b86f2f009c 100644 --- a/plugins/kotlin/refactorings/kotlin.refactorings.k2/src/org/jetbrains/kotlin/idea/k2/refactoring/extractFunction/ui/KotlinFirExtractFunctionDialog.java +++ b/plugins/kotlin/refactorings/kotlin.refactorings.k2/src/org/jetbrains/kotlin/idea/k2/refactoring/extractFunction/ui/KotlinFirExtractFunctionDialog.java @@ -82,6 +82,7 @@ public class KotlinFirExtractFunctionDialog extends DialogWrapper { private final Function1 onAccept; + @SuppressWarnings("HardCodedStringLiteral") public KotlinFirExtractFunctionDialog( @NotNull Project project, @NotNull ExtractableCodeDescriptorWithConflicts originalDescriptor, diff --git a/plugins/lombok/src/main/java/de/plushnikov/intellij/plugin/settings/ProjectSettingsPage.java b/plugins/lombok/src/main/java/de/plushnikov/intellij/plugin/settings/ProjectSettingsPage.java index ce8be2b571ae..a748344cfd8d 100644 --- a/plugins/lombok/src/main/java/de/plushnikov/intellij/plugin/settings/ProjectSettingsPage.java +++ b/plugins/lombok/src/main/java/de/plushnikov/intellij/plugin/settings/ProjectSettingsPage.java @@ -31,6 +31,7 @@ public final class ProjectSettingsPage implements SearchableConfigurable, Config private final JCheckBox myEnableJSPFix; private final Project myProject; + @SuppressWarnings("HardCodedStringLiteral") public ProjectSettingsPage(Project project) { myProject = project; { diff --git a/plugins/tasks/tasks-core/src/com/intellij/tasks/generic/GenericRepositoryEditor.java b/plugins/tasks/tasks-core/src/com/intellij/tasks/generic/GenericRepositoryEditor.java index 0f3e57d86793..728ab2160d08 100644 --- a/plugins/tasks/tasks-core/src/com/intellij/tasks/generic/GenericRepositoryEditor.java +++ b/plugins/tasks/tasks-core/src/com/intellij/tasks/generic/GenericRepositoryEditor.java @@ -75,6 +75,7 @@ public class GenericRepositoryEditor extends BaseRe private Map myField2Variable; private final Map myRadio2ResponseType; + @SuppressWarnings("HardCodedStringLiteral") public GenericRepositoryEditor(final Project project, final T repository, final Consumer changeListener) { diff --git a/python/src/com/jetbrains/python/documentation/PythonDocumentationEntryEditor.java b/python/src/com/jetbrains/python/documentation/PythonDocumentationEntryEditor.java index 22c58bd835ae..342abea4d08f 100644 --- a/python/src/com/jetbrains/python/documentation/PythonDocumentationEntryEditor.java +++ b/python/src/com/jetbrains/python/documentation/PythonDocumentationEntryEditor.java @@ -39,6 +39,7 @@ public class PythonDocumentationEntryEditor extends DialogWrapper { private final JButton myInsertButton; private final JBList myMacroList; + @SuppressWarnings("HardCodedStringLiteral") public PythonDocumentationEntryEditor(Component parent) { super(parent, true); { diff --git a/python/src/com/jetbrains/python/refactoring/introduce/field/PyIntroduceFieldPanel.java b/python/src/com/jetbrains/python/refactoring/introduce/field/PyIntroduceFieldPanel.java index 25c81b8de35e..1e7bfe18281e 100644 --- a/python/src/com/jetbrains/python/refactoring/introduce/field/PyIntroduceFieldPanel.java +++ b/python/src/com/jetbrains/python/refactoring/introduce/field/PyIntroduceFieldPanel.java @@ -25,6 +25,7 @@ public class PyIntroduceFieldPanel { private final JPanel myRootPanel; private final JComboBox myInitializerPlaceCombo; + @SuppressWarnings("HardCodedStringLiteral") public PyIntroduceFieldPanel(Project project, EnumSet initPlaces) { { // GUI initializer generated by IntelliJ IDEA GUI Designer diff --git a/xml/xml-ui-common/src/com/intellij/application/options/CodeStyleXmlPanel.java b/xml/xml-ui-common/src/com/intellij/application/options/CodeStyleXmlPanel.java index ea8a30996578..dba8c29f1b9a 100644 --- a/xml/xml-ui-common/src/com/intellij/application/options/CodeStyleXmlPanel.java +++ b/xml/xml-ui-common/src/com/intellij/application/options/CodeStyleXmlPanel.java @@ -57,6 +57,7 @@ public class CodeStyleXmlPanel extends CodeStyleAbstractPanel { private final JPanel myRightMarginPanel; private RightMarginForm myRightMarginForm; + @SuppressWarnings("HardCodedStringLiteral") public CodeStyleXmlPanel(CodeStyleSettings settings) { super(settings); {