From 9ffddb0e0a1a0903fe9bf60cc7d92a203f59f5ad Mon Sep 17 00:00:00 2001 From: Vladimir Krivosheev Date: Mon, 3 Nov 2014 09:41:30 +0100 Subject: [PATCH] simplify --- .../src/org/jetbrains/debugger/BreakpointTarget.java | 12 ++++++++++++ .../debugger/ScriptRegExpBreakpointTarget.java | 5 +++++ .../org/jetbrains/debugger/ScriptRegExpSupport.java | 5 +---- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/platform/script-debugger/backend/src/org/jetbrains/debugger/BreakpointTarget.java b/platform/script-debugger/backend/src/org/jetbrains/debugger/BreakpointTarget.java index 604b08d8bfd4..8df82e121580 100644 --- a/platform/script-debugger/backend/src/org/jetbrains/debugger/BreakpointTarget.java +++ b/platform/script-debugger/backend/src/org/jetbrains/debugger/BreakpointTarget.java @@ -43,6 +43,11 @@ public abstract class BreakpointTarget { return visitor.visitScript(script); } + @Override + public String toString() { + return script.toString(); + } + @Override public boolean equals(Object o) { if (this == o) { @@ -61,6 +66,8 @@ public abstract class BreakpointTarget { } } + public abstract String toString(); + /** * A target that refers to a script by its name. Breakpoint will be set on every matching script currently loaded in VM. */ @@ -76,6 +83,11 @@ public abstract class BreakpointTarget { return name; } + @Override + public String toString() { + return name; + } + @Override public R accept(@NotNull Visitor visitor) { return visitor.visitScriptName(name); diff --git a/platform/script-debugger/backend/src/org/jetbrains/debugger/ScriptRegExpBreakpointTarget.java b/platform/script-debugger/backend/src/org/jetbrains/debugger/ScriptRegExpBreakpointTarget.java index 8f9f511e05e6..4bc4b9ad54e8 100644 --- a/platform/script-debugger/backend/src/org/jetbrains/debugger/ScriptRegExpBreakpointTarget.java +++ b/platform/script-debugger/backend/src/org/jetbrains/debugger/ScriptRegExpBreakpointTarget.java @@ -19,6 +19,11 @@ public final class ScriptRegExpBreakpointTarget extends BreakpointTarget { } } + @Override + public String toString() { + return regExp; + } + @Override public boolean equals(Object o) { if (this == o) { diff --git a/platform/script-debugger/backend/src/org/jetbrains/debugger/ScriptRegExpSupport.java b/platform/script-debugger/backend/src/org/jetbrains/debugger/ScriptRegExpSupport.java index 02dffe26ba01..88be0e76ae83 100644 --- a/platform/script-debugger/backend/src/org/jetbrains/debugger/ScriptRegExpSupport.java +++ b/platform/script-debugger/backend/src/org/jetbrains/debugger/ScriptRegExpSupport.java @@ -1,10 +1,7 @@ package org.jetbrains.debugger; /** - * Supports targets that refer to a script by a 'regexp' of its name. - * After {@link Vm#setBreakpoint} is - * called, breakpoint will be set on every script currently loaded in VM whose name matches. - * E.g. you can safely set a breakpoint before the script is actually loaded. + * Supports targets that refer to a script by a 'regexp' of its name */ public interface ScriptRegExpSupport { /**