From 9fd6f207295c595ade95570e9c617487b2965ea3 Mon Sep 17 00:00:00 2001 From: Roman Shevchenko Date: Fri, 9 Sep 2016 11:16:12 +0300 Subject: [PATCH] [java] "Find .jar" / "Add Maven dependency" are not applicable in module-info files --- .../jarFinder/FindJarQuickFixProvider.java | 22 +++++++++++++++++-- .../ResolveReferenceQuickFixProvider.java | 12 ++++++---- 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/java/java-impl/src/com/intellij/jarFinder/FindJarQuickFixProvider.java b/java/java-impl/src/com/intellij/jarFinder/FindJarQuickFixProvider.java index fbf7ae96c57a..76c552c0af71 100644 --- a/java/java-impl/src/com/intellij/jarFinder/FindJarQuickFixProvider.java +++ b/java/java-impl/src/com/intellij/jarFinder/FindJarQuickFixProvider.java @@ -1,8 +1,24 @@ +/* + * Copyright 2000-2016 JetBrains s.r.o. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package com.intellij.jarFinder; import com.intellij.codeInsight.daemon.QuickFixActionRegistrar; import com.intellij.codeInsight.quickfix.UnresolvedReferenceQuickFixProvider; import com.intellij.psi.PsiJavaCodeReferenceElement; +import com.intellij.psi.util.PsiUtil; import org.jetbrains.annotations.NotNull; /** @@ -11,7 +27,9 @@ import org.jetbrains.annotations.NotNull; public class FindJarQuickFixProvider extends UnresolvedReferenceQuickFixProvider { @Override public void registerFixes(@NotNull PsiJavaCodeReferenceElement ref, @NotNull QuickFixActionRegistrar registrar) { - registrar.register(new JavaFindJarFix(ref)); + if (!PsiUtil.isModuleFile(ref.getContainingFile())) { + registrar.register(new JavaFindJarFix(ref)); + } } @NotNull @@ -19,4 +37,4 @@ public class FindJarQuickFixProvider extends UnresolvedReferenceQuickFixProvider public Class getReferenceClass() { return PsiJavaCodeReferenceElement.class; } -} +} \ No newline at end of file diff --git a/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/intentions/ResolveReferenceQuickFixProvider.java b/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/intentions/ResolveReferenceQuickFixProvider.java index 3ce874bd008f..faf342c2ebcc 100644 --- a/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/intentions/ResolveReferenceQuickFixProvider.java +++ b/plugins/maven/src/main/java/org/jetbrains/idea/maven/dom/intentions/ResolveReferenceQuickFixProvider.java @@ -1,5 +1,5 @@ /* - * Copyright 2000-2009 JetBrains s.r.o. + * Copyright 2000-2016 JetBrains s.r.o. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -18,16 +18,20 @@ package org.jetbrains.idea.maven.dom.intentions; import com.intellij.codeInsight.daemon.QuickFixActionRegistrar; import com.intellij.codeInsight.quickfix.UnresolvedReferenceQuickFixProvider; import com.intellij.psi.PsiJavaCodeReferenceElement; +import com.intellij.psi.util.PsiUtil; import org.jetbrains.annotations.NotNull; public class ResolveReferenceQuickFixProvider extends UnresolvedReferenceQuickFixProvider { - + @Override public void registerFixes(@NotNull PsiJavaCodeReferenceElement ref, @NotNull QuickFixActionRegistrar registrar) { - registrar.register(new AddMavenDependencyQuickFix(ref)); + if (!PsiUtil.isModuleFile(ref.getContainingFile())) { + registrar.register(new AddMavenDependencyQuickFix(ref)); + } } @NotNull + @Override public Class getReferenceClass() { return PsiJavaCodeReferenceElement.class; } -} +} \ No newline at end of file