diff --git a/platform/vcs-log/graph-api/src/com/intellij/vcs/log/graph/PermanentGraph.java b/platform/vcs-log/graph-api/src/com/intellij/vcs/log/graph/PermanentGraph.java index db16ac3a54ca..e9da79884dc7 100644 --- a/platform/vcs-log/graph-api/src/com/intellij/vcs/log/graph/PermanentGraph.java +++ b/platform/vcs-log/graph-api/src/com/intellij/vcs/log/graph/PermanentGraph.java @@ -15,7 +15,6 @@ */ package com.intellij.vcs.log.graph; -import com.intellij.openapi.util.Condition; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -34,7 +33,7 @@ public interface PermanentGraph { @NotNull VisibleGraph createVisibleGraph(@NotNull SortType sortType, @Nullable Set headsOfVisibleBranches, - @Nullable Condition filter); + @Nullable Set matchedCommits); @NotNull List> getAllCommits(); diff --git a/platform/vcs-log/graph/src/com/intellij/vcs/log/graph/impl/facade/PermanentGraphImpl.java b/platform/vcs-log/graph/src/com/intellij/vcs/log/graph/impl/facade/PermanentGraphImpl.java index ea8015360147..bd15ac79d489 100644 --- a/platform/vcs-log/graph/src/com/intellij/vcs/log/graph/impl/facade/PermanentGraphImpl.java +++ b/platform/vcs-log/graph/src/com/intellij/vcs/log/graph/impl/facade/PermanentGraphImpl.java @@ -17,7 +17,6 @@ package com.intellij.vcs.log.graph.impl.facade; -import com.intellij.openapi.util.Condition; import com.intellij.util.NotNullFunction; import com.intellij.util.containers.ContainerUtil; import com.intellij.vcs.log.graph.*; @@ -106,7 +105,7 @@ public class PermanentGraphImpl implements PermanentGraph, P @Override public VisibleGraph createVisibleGraph(@NotNull SortType sortType, @Nullable Set headsOfVisibleBranches, - @Nullable Condition filter) { + @Nullable Set filter) { CascadeLinearGraphController controller; if (sortType == SortType.Bek) { controller = new CollapsedLinearGraphController(new BekBaseLinearGraphController(this, myBekIntMap), this); diff --git a/platform/vcs-log/impl/src/com/intellij/vcs/log/data/EmptyPermanentGraph.java b/platform/vcs-log/impl/src/com/intellij/vcs/log/data/EmptyPermanentGraph.java index 5c5eb9cb68ed..cfdf3212307a 100644 --- a/platform/vcs-log/impl/src/com/intellij/vcs/log/data/EmptyPermanentGraph.java +++ b/platform/vcs-log/impl/src/com/intellij/vcs/log/data/EmptyPermanentGraph.java @@ -15,7 +15,6 @@ */ package com.intellij.vcs.log.data; -import com.intellij.openapi.util.Condition; import com.intellij.vcs.log.graph.GraphCommit; import com.intellij.vcs.log.graph.PermanentGraph; import com.intellij.vcs.log.graph.VisibleGraph; @@ -38,7 +37,7 @@ public class EmptyPermanentGraph implements PermanentGraph { @NotNull @Override public VisibleGraph createVisibleGraph(@NotNull SortType sortType, @Nullable Set headsOfVisibleBranches, - @Nullable Condition filter) { + @Nullable Set filter) { return EmptyVisibleGraph.getInstance(); } diff --git a/platform/vcs-log/impl/src/com/intellij/vcs/log/data/VisiblePackBuilder.java b/platform/vcs-log/impl/src/com/intellij/vcs/log/data/VisiblePackBuilder.java index 7117a7df357b..abeef21f23b2 100644 --- a/platform/vcs-log/impl/src/com/intellij/vcs/log/data/VisiblePackBuilder.java +++ b/platform/vcs-log/impl/src/com/intellij/vcs/log/data/VisiblePackBuilder.java @@ -97,7 +97,7 @@ class VisiblePackBuilder { visibleGraph = EmptyVisibleGraph.getInstance(); } else { - visibleGraph = dataPack.getPermanentGraph().createVisibleGraph(sortType, matchingHeads, getFilterFromCommits(matchingCommits)); + visibleGraph = dataPack.getPermanentGraph().createVisibleGraph(sortType, matchingHeads, getMatchedCommitIndex(matchingCommits)); } return Pair.create(new VisiblePack(dataPack, visibleGraph, canRequestMore), commitCount); } @@ -116,12 +116,7 @@ class VisiblePackBuilder { return hash != null ? myHashMap.getCommitIndex(hash) : null; } }); - VisibleGraph visibleGraph = dataPack.getPermanentGraph().createVisibleGraph(sortType, null, new Condition() { - @Override - public boolean value(Integer integer) { - return indices.contains(integer); - } - }); + VisibleGraph visibleGraph = dataPack.getPermanentGraph().createVisibleGraph(sortType, null, indices); return new VisiblePack(dataPack, visibleGraph, false); } @@ -272,23 +267,17 @@ class VisiblePackBuilder { } @Nullable - private Condition getFilterFromCommits(@Nullable List filteredCommits) { - if (filteredCommits == null) { + private Set getMatchedCommitIndex(@Nullable List commits) { + if (commits == null) { return null; } - final Set commitSet = ContainerUtil.map2Set(filteredCommits, new Function() { + return ContainerUtil.map2Set(commits, new Function() { @Override public Integer fun(Hash hash) { return myHashMap.getCommitIndex(hash); } }); - return new Condition() { - @Override - public boolean value(Integer integer) { - return commitSet.contains(integer); - } - }; } }