From 9aae32ce1e4417fa65afd260d990d9d4da8bd40a Mon Sep 17 00:00:00 2001 From: Bogdan Kirilenko Date: Wed, 22 Jan 2025 14:25:13 +0100 Subject: [PATCH] [PyCharm] PY-77045 per cell actions toolbar shown only for selected cells / fixed bug with "not shown for newly created cell" GitOrigin-RevId: b8a1e9a3c456a7bfaebead2131fcef19679cb1d5 --- .../visualization/ui/EditorCellActionsToolbarManager.kt | 2 -- .../com/intellij/notebooks/visualization/ui/EditorCellView.kt | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/notebooks/visualization/src/com/intellij/notebooks/visualization/ui/EditorCellActionsToolbarManager.kt b/notebooks/visualization/src/com/intellij/notebooks/visualization/ui/EditorCellActionsToolbarManager.kt index 43f7ebdb1d56..d2099d68c60d 100644 --- a/notebooks/visualization/src/com/intellij/notebooks/visualization/ui/EditorCellActionsToolbarManager.kt +++ b/notebooks/visualization/src/com/intellij/notebooks/visualization/ui/EditorCellActionsToolbarManager.kt @@ -34,8 +34,6 @@ class EditorCellActionsToolbarManager(private val editor: EditorEx, private val fun showToolbar(targetComponent: JComponent) { val actionGroup = getActionGroup(cell.interval.type) ?: return - if (targetComponent.width == 0 || targetComponent.height == 0) return - removeToolbar() toolbar = JupyterCellActionsToolbar(actionGroup, targetComponent) diff --git a/notebooks/visualization/src/com/intellij/notebooks/visualization/ui/EditorCellView.kt b/notebooks/visualization/src/com/intellij/notebooks/visualization/ui/EditorCellView.kt index efc29631d9f1..98ee0d22afb1 100644 --- a/notebooks/visualization/src/com/intellij/notebooks/visualization/ui/EditorCellView.kt +++ b/notebooks/visualization/src/com/intellij/notebooks/visualization/ui/EditorCellView.kt @@ -266,7 +266,6 @@ class EditorCellView( updateFolding() updateRunButtonVisibility() myEditorCellFrameManager?.updateMarkdownCellShow(mouseOver || selected) - updateCellActionsToolbarVisibility() } fun mouseEntered() { @@ -274,7 +273,6 @@ class EditorCellView( updateFolding() updateRunButtonVisibility() myEditorCellFrameManager?.updateMarkdownCellShow(mouseOver || selected) - updateCellActionsToolbarVisibility() } inline fun getExtension(): T? { @@ -376,7 +374,7 @@ class EditorCellView( private fun updateCellActionsToolbarVisibility() { input.cellActionsToolbar ?: return - when (selected || mouseOver) { + when (selected) { true -> { val targetComponent = _controllers.filterIsInstance().firstOrNull()?.retrieveDataProvider() ?: return input.cellActionsToolbar.showToolbar(targetComponent)