From 9a6e09563b58aa0ae67b7121eb98e5e221d8fdbf Mon Sep 17 00:00:00 2001 From: Nadya Zabrodina Date: Mon, 2 Nov 2015 14:58:01 +0300 Subject: [PATCH] [git]: style: make common illegal pattern --- .../src/git4idea/validators/GitRefNameValidator.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/git4idea/src/git4idea/validators/GitRefNameValidator.java b/plugins/git4idea/src/git4idea/validators/GitRefNameValidator.java index 8a0583d45169..c83b71dc5807 100644 --- a/plugins/git4idea/src/git4idea/validators/GitRefNameValidator.java +++ b/plugins/git4idea/src/git4idea/validators/GitRefNameValidator.java @@ -25,7 +25,6 @@ import java.util.regex.Pattern; * See * http://www.kernel.org/pub/software/scm/git/docs/git-check-ref-format.html * - * @author Kirill Likhodedov */ public final class GitRefNameValidator implements InputValidator { @@ -45,6 +44,7 @@ public final class GitRefNameValidator implements InputValidator { } private static final Pattern ILLEGAL = Pattern.compile( "(^\\.)|" + // begins with a dot + "(^-)|" + // begins with '-' "[ ~:\\^\\?\\*\\[\\\\]+|(@\\{)+|" + // contains invalid character: space, one of ~:^?*[\ or @{ sequence "(\\.\\.)+|" + // two dots in a row "(([\\./]|\\.lock)$)|" + // ends with dot, slash or ".lock" @@ -59,9 +59,7 @@ public final class GitRefNameValidator implements InputValidator { @Override public boolean checkInput(String inputString) { - return !StringUtil.isEmptyOrSpaces(inputString) && - !ILLEGAL.matcher(inputString).find() && - !inputString.startsWith("-"); + return !StringUtil.isEmptyOrSpaces(inputString) && !ILLEGAL.matcher(inputString).find(); } @Override