From 97c089ccf718c8c3871d31cb0a83b7298dab5209 Mon Sep 17 00:00:00 2001 From: peter Date: Wed, 17 Oct 2012 16:22:09 +0200 Subject: [PATCH] EA-40088 - PIEAE: PsiElementBase.getContainingFile (validity assertions) --- .../src/com/intellij/codeInsight/ExpectedTypeInfoImpl.java | 3 +++ .../intellij/codeInsight/completion/JavaCompletionSorting.java | 3 +++ java/java-psi-api/src/com/intellij/psi/PsiPrimitiveType.java | 1 + 3 files changed, 7 insertions(+) diff --git a/java/java-impl/src/com/intellij/codeInsight/ExpectedTypeInfoImpl.java b/java/java-impl/src/com/intellij/codeInsight/ExpectedTypeInfoImpl.java index d7ea3164ffce..63d7a8932ef1 100644 --- a/java/java-impl/src/com/intellij/codeInsight/ExpectedTypeInfoImpl.java +++ b/java/java-impl/src/com/intellij/codeInsight/ExpectedTypeInfoImpl.java @@ -82,6 +82,9 @@ public class ExpectedTypeInfoImpl implements ExpectedTypeInfo { } this.defaultType = defaultType; + + assert type.isValid(); + assert defaultType.isValid(); } @Override diff --git a/java/java-impl/src/com/intellij/codeInsight/completion/JavaCompletionSorting.java b/java/java-impl/src/com/intellij/codeInsight/completion/JavaCompletionSorting.java index e113fa2159d9..9f281aa51cf8 100644 --- a/java/java-impl/src/com/intellij/codeInsight/completion/JavaCompletionSorting.java +++ b/java/java-impl/src/com/intellij/codeInsight/completion/JavaCompletionSorting.java @@ -177,6 +177,9 @@ public class JavaCompletionSorting { final PsiType defaultType = expectedInfo.getDefaultType(); final PsiType expectedType = expectedInfo.getType(); + assert expectedType.isValid(); + assert defaultType.isValid(); + if (defaultType != expectedType && defaultType.isAssignableFrom(itemType)) { return ExpectedTypeMatching.ofDefaultType; } diff --git a/java/java-psi-api/src/com/intellij/psi/PsiPrimitiveType.java b/java/java-psi-api/src/com/intellij/psi/PsiPrimitiveType.java index 5e2d80fd6e0d..acbbfdfdb014 100644 --- a/java/java-psi-api/src/com/intellij/psi/PsiPrimitiveType.java +++ b/java/java-psi-api/src/com/intellij/psi/PsiPrimitiveType.java @@ -104,6 +104,7 @@ public class PsiPrimitiveType extends PsiType { @Nullable public static PsiPrimitiveType getUnboxedType(PsiType type) { if (!(type instanceof PsiClassType)) return null; + assert type.isValid(); if (!((PsiClassType)type).getLanguageLevel().isAtLeast(LanguageLevel.JDK_1_5)) return null; final PsiClass psiClass = ((PsiClassType)type).resolve(); if (psiClass == null) return null;