From 95e25d28419560361b17ba151ec5331d3e1f58dc Mon Sep 17 00:00:00 2001 From: Mikhail Golubev Date: Mon, 1 Sep 2014 17:29:08 +0400 Subject: [PATCH] IDEA-126470 Filed 'description' in Redmine issues may be missing --- .../intellij/tasks/redmine/model/RedmineIssue.java | 4 ++-- .../tasks/integration/RedmineIntegrationTest.java | 12 ++++++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/plugins/tasks/tasks-core/src/com/intellij/tasks/redmine/model/RedmineIssue.java b/plugins/tasks/tasks-core/src/com/intellij/tasks/redmine/model/RedmineIssue.java index 07b5669a1540..aea41bdb6ca8 100644 --- a/plugins/tasks/tasks-core/src/com/intellij/tasks/redmine/model/RedmineIssue.java +++ b/plugins/tasks/tasks-core/src/com/intellij/tasks/redmine/model/RedmineIssue.java @@ -19,7 +19,7 @@ public class RedmineIssue { private IssueStatus status; @Mandatory private String subject; - @Mandatory + // IDEA-126470 May be missing if issue was not created via web-interface private String description; @SerializedName("done_ratio") private int doneRatio; @@ -45,7 +45,7 @@ public class RedmineIssue { return subject; } - @NotNull + @Nullable public String getDescription() { return description; } diff --git a/plugins/tasks/tasks-tests/test/com/intellij/tasks/integration/RedmineIntegrationTest.java b/plugins/tasks/tasks-tests/test/com/intellij/tasks/integration/RedmineIntegrationTest.java index fa4d40dc2750..16dbd42addb5 100644 --- a/plugins/tasks/tasks-tests/test/com/intellij/tasks/integration/RedmineIntegrationTest.java +++ b/plugins/tasks/tasks-tests/test/com/intellij/tasks/integration/RedmineIntegrationTest.java @@ -21,11 +21,11 @@ public class RedmineIntegrationTest extends TaskManagerTestCase { // with closed issues Task[] found = myRepository.getIssues(null, 0, 25, true); - assertEquals(4, found.length); + assertEquals(5, found.length); // without closed issues found = myRepository.getIssues(null, 0, 25, false); - assertEquals(3, found.length); + assertEquals(4, found.length); // unique summary //found = myRepository.getIssues("baz", 0, 25, true); @@ -72,6 +72,14 @@ public class RedmineIntegrationTest extends TaskManagerTestCase { } } + // IDEA-126470 + public void testIssueWithMissingDescription() throws Exception { + final Task issue = myRepository.findTask("8"); + assertNotNull(issue); + assertNull(issue.getDescription()); + assertEquals(issue.getSummary(), "Artificial issue with no description created via REST API"); + } + @Override public void setUp() throws Exception { super.setUp();