From 94c327dc6c1d400e1bb4d62c2b966be4beee707b Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Thu, 14 Dec 2023 13:06:00 +0100 Subject: [PATCH] [java-inspections] IgnoreResultOfCallInspection: hard-code java.time parse methods as throwing DateTimeParseException GitOrigin-RevId: 207fccac40251f81e9cac1ec3494d280b7a48554 --- .../ig/bugs/IgnoreResultOfCallInspection.java | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/java/java-impl/src/com/siyeh/ig/bugs/IgnoreResultOfCallInspection.java b/java/java-impl/src/com/siyeh/ig/bugs/IgnoreResultOfCallInspection.java index 3834d92a1e72..5cdaf80d6472 100644 --- a/java/java-impl/src/com/siyeh/ig/bugs/IgnoreResultOfCallInspection.java +++ b/java/java-impl/src/com/siyeh/ig/bugs/IgnoreResultOfCallInspection.java @@ -70,7 +70,21 @@ public final class IgnoreResultOfCallInspection extends BaseInspection { "getMethod", "getDeclaredMethod", "getConstructor", "getDeclaredConstructor"), "java.lang.NoSuchMethodException") .register(CallMatcher.instanceCall(CommonClassNames.JAVA_LANG_CLASS, - "getField", "getDeclaredField"), "java.lang.NoSuchFieldException"); + "getField", "getDeclaredField"), "java.lang.NoSuchFieldException") + .register(CallMatcher.anyOf( + CallMatcher.instanceCall("java.time.format.DateTimeFormatter", "parse", "parseBest"), + CallMatcher.staticCall("java.time.Duration", "parse"), + CallMatcher.staticCall("java.time.Instant", "parse"), + CallMatcher.staticCall("java.time.MonthDay", "parse"), + CallMatcher.staticCall("java.time.Period", "parse"), + CallMatcher.staticCall("java.time.Year", "parse"), + CallMatcher.staticCall("java.time.YearMonth", "parse"), + CallMatcher.staticCall(CommonClassNames.JAVA_TIME_OFFSET_TIME, "parse"), + CallMatcher.staticCall(CommonClassNames.JAVA_TIME_OFFSET_DATE_TIME, "parse"), + CallMatcher.staticCall(CommonClassNames.JAVA_TIME_ZONED_DATE_TIME, "parse"), + CallMatcher.staticCall(CommonClassNames.JAVA_TIME_LOCAL_DATE, "parse"), + CallMatcher.staticCall(CommonClassNames.JAVA_TIME_LOCAL_DATE_TIME, "parse"), + CallMatcher.staticCall(CommonClassNames.JAVA_TIME_LOCAL_TIME, "parse")), "java.time.format.DateTimeParseException"); private static final CallMatcher MOCK_LIBS_EXCLUDED_QUALIFIER_CALLS = CallMatcher.anyOf( CallMatcher.instanceCall("org.mockito.stubbing.Stubber", "when"),