diff --git a/plugins/grazie/src/main/kotlin/com/intellij/grazie/text/LiteralProblemFilter.kt b/plugins/grazie/src/main/kotlin/com/intellij/grazie/text/LiteralProblemFilter.kt index 781a210b1ead..1bfa63175d7b 100644 --- a/plugins/grazie/src/main/kotlin/com/intellij/grazie/text/LiteralProblemFilter.kt +++ b/plugins/grazie/src/main/kotlin/com/intellij/grazie/text/LiteralProblemFilter.kt @@ -1,14 +1,8 @@ package com.intellij.grazie.text -import com.intellij.grazie.utils.Text - /** Enable this filter for your language to filter [RuleGroup.LITERALS] in its string literals */ class LiteralProblemFilter : ProblemFilter() { - private val ignoredRules = RuleGroup.LITERALS - override fun shouldIgnore(problem: TextProblem): Boolean { - return problem.text.domain == TextContent.TextDomain.LITERALS && - Text.isSingleSentence(problem.text) && - problem.fitsGroup(ignoredRules) + return problem.text.domain == TextContent.TextDomain.LITERALS && problem.fitsGroup(RuleGroup.LITERALS) } } \ No newline at end of file diff --git a/plugins/grazie/src/test/testData/ide/language/java/StringLiterals.java b/plugins/grazie/src/test/testData/ide/language/java/StringLiterals.java index e42b807956f7..f8df6e4f64c9 100644 --- a/plugins/grazie/src/test/testData/ide/language/java/StringLiterals.java +++ b/plugins/grazie/src/test/testData/ide/language/java/StringLiterals.java @@ -18,6 +18,8 @@ class Main { System.out.println("The path is ../data/test.avi"); } + String messagePart = "; fragment of one sentence. This is another sentence,"; + String gitCherryPickPattern = "(cherry picked from "; // hard-coding the string git outputs String nonGitCherryPick = "I'd like to cherry pick this"; } diff --git a/plugins/kotlin/grazie/resources/kotlin.grazie.xml b/plugins/kotlin/grazie/resources/kotlin.grazie.xml index 6b37478c15e3..26ccda9e15ae 100644 --- a/plugins/kotlin/grazie/resources/kotlin.grazie.xml +++ b/plugins/kotlin/grazie/resources/kotlin.grazie.xml @@ -6,5 +6,6 @@ + \ No newline at end of file diff --git a/plugins/kotlin/grazie/src/org/jetbrains/kotlin/idea/grazie/KotlinProblemFilter.kt b/plugins/kotlin/grazie/src/org/jetbrains/kotlin/idea/grazie/KotlinProblemFilter.kt index 675abfc6d2b3..573049173260 100644 --- a/plugins/kotlin/grazie/src/org/jetbrains/kotlin/idea/grazie/KotlinProblemFilter.kt +++ b/plugins/kotlin/grazie/src/org/jetbrains/kotlin/idea/grazie/KotlinProblemFilter.kt @@ -2,9 +2,7 @@ package org.jetbrains.kotlin.idea.grazie import com.intellij.grazie.text.ProblemFilter -import com.intellij.grazie.text.RuleGroup import com.intellij.grazie.text.TextContent.TextDomain.DOCUMENTATION -import com.intellij.grazie.text.TextContent.TextDomain.LITERALS import com.intellij.grazie.text.TextProblem import com.intellij.grazie.utils.ProblemFilterUtil import org.jetbrains.kotlin.kdoc.psi.impl.KDocTag @@ -12,9 +10,6 @@ import org.jetbrains.kotlin.kdoc.psi.impl.KDocTag class KotlinProblemFilter : ProblemFilter() { override fun shouldIgnore(problem: TextProblem): Boolean { val domain = problem.text.domain - if (domain == LITERALS) { - return problem.fitsGroup(RuleGroup.LITERALS) - } if (domain == DOCUMENTATION && problem.text.commonParent::class == KDocTag::class && (ProblemFilterUtil.isUndecoratedSingleSentenceIssue(problem) || ProblemFilterUtil.isInitialCasingIssue(problem))) { return true diff --git a/python/python-grazie/src/com/intellij/python/grazie/PythonProblemFilter.kt b/python/python-grazie/src/com/intellij/python/grazie/PythonProblemFilter.kt index f021eefb647c..f302aa4c9cf1 100644 --- a/python/python-grazie/src/com/intellij/python/grazie/PythonProblemFilter.kt +++ b/python/python-grazie/src/com/intellij/python/grazie/PythonProblemFilter.kt @@ -9,15 +9,9 @@ import com.intellij.grazie.utils.ProblemFilterUtil class PythonProblemFilter : ProblemFilter() { override fun shouldIgnore(problem: TextProblem): Boolean { val domain = problem.text.domain - if (domain == TextContent.TextDomain.LITERALS) { - return problem.fitsGroup(RuleGroup.LITERALS) - } - if (domain == TextContent.TextDomain.DOCUMENTATION && - (ProblemFilterUtil.isUndecoratedSingleSentenceIssue(problem) || - ProblemFilterUtil.isInitialCasingIssue(problem) || - problem.fitsGroup(RuleGroup(RuleGroup.UNDECORATED_SENTENCE_SEPARATION)))) { - return true - } - return false + return domain == TextContent.TextDomain.DOCUMENTATION && + (ProblemFilterUtil.isUndecoratedSingleSentenceIssue(problem) || + ProblemFilterUtil.isInitialCasingIssue(problem) || + problem.fitsGroup(RuleGroup(RuleGroup.UNDECORATED_SENTENCE_SEPARATION))) } } \ No newline at end of file