From 930d87bc93760d1a5c3e3e911312480d83c8d11e Mon Sep 17 00:00:00 2001 From: nik Date: Wed, 24 Sep 2014 17:58:28 +0400 Subject: [PATCH] FacetEditorTab#createComponent annotated as @NotNull --- .../lang-api/src/com/intellij/facet/ui/FacetEditorTab.java | 3 +++ .../com/intellij/facet/impl/invalid/InvalidFacetEditor.java | 2 ++ .../com/intellij/appengine/facet/AppEngineFacetEditor.java | 1 + .../com/jetbrains/python/facet/PythonSdkEditorTab.java | 2 ++ .../jetbrains/python/buildout/BuildoutFacetConfiguration.java | 2 ++ 5 files changed, 10 insertions(+) diff --git a/platform/lang-api/src/com/intellij/facet/ui/FacetEditorTab.java b/platform/lang-api/src/com/intellij/facet/ui/FacetEditorTab.java index fbb52d5875a8..8d0b180dc5e0 100644 --- a/platform/lang-api/src/com/intellij/facet/ui/FacetEditorTab.java +++ b/platform/lang-api/src/com/intellij/facet/ui/FacetEditorTab.java @@ -31,6 +31,9 @@ import javax.swing.*; * @author nik */ public abstract class FacetEditorTab implements Configurable { + @NotNull + @Override + public abstract JComponent createComponent(); @Override @Nullable diff --git a/platform/lang-impl/src/com/intellij/facet/impl/invalid/InvalidFacetEditor.java b/platform/lang-impl/src/com/intellij/facet/impl/invalid/InvalidFacetEditor.java index 2191b008c0e4..e1a3c5fd7e42 100644 --- a/platform/lang-impl/src/com/intellij/facet/impl/invalid/InvalidFacetEditor.java +++ b/platform/lang-impl/src/com/intellij/facet/impl/invalid/InvalidFacetEditor.java @@ -20,6 +20,7 @@ import com.intellij.facet.ui.FacetEditorTab; import com.intellij.icons.AllIcons; import com.intellij.openapi.ui.ex.MultiLineLabel; import org.jetbrains.annotations.Nls; +import org.jetbrains.annotations.NotNull; import javax.swing.*; @@ -51,6 +52,7 @@ public class InvalidFacetEditor extends FacetEditorTab { return myIgnoreCheckBox; } + @NotNull @Override public JComponent createComponent() { myIconLabel.setIcon(AllIcons.RunConfigurations.ConfigurationWarning); diff --git a/plugins/google-app-engine/source/com/intellij/appengine/facet/AppEngineFacetEditor.java b/plugins/google-app-engine/source/com/intellij/appengine/facet/AppEngineFacetEditor.java index a01878f1e29d..e8c92ad9b5d3 100644 --- a/plugins/google-app-engine/source/com/intellij/appengine/facet/AppEngineFacetEditor.java +++ b/plugins/google-app-engine/source/com/intellij/appengine/facet/AppEngineFacetEditor.java @@ -105,6 +105,7 @@ public class AppEngineFacetEditor extends FacetEditorTab { return "Google App Engine"; } + @NotNull public JComponent createComponent() { mySdkEditorPanel.add(BorderLayout.CENTER, mySdkEditor.getMainComponent()); return myMainPanel; diff --git a/python/pluginSrc/com/jetbrains/python/facet/PythonSdkEditorTab.java b/python/pluginSrc/com/jetbrains/python/facet/PythonSdkEditorTab.java index 7863cdf1b6c5..03f05b6be861 100644 --- a/python/pluginSrc/com/jetbrains/python/facet/PythonSdkEditorTab.java +++ b/python/pluginSrc/com/jetbrains/python/facet/PythonSdkEditorTab.java @@ -23,6 +23,7 @@ import com.intellij.openapi.projectRoots.Sdk; import com.intellij.openapi.util.Disposer; import com.intellij.util.messages.MessageBusConnection; import org.jetbrains.annotations.Nls; +import org.jetbrains.annotations.NotNull; import javax.swing.*; @@ -63,6 +64,7 @@ public class PythonSdkEditorTab extends FacetEditorTab { return "Python SDK"; } + @NotNull public JComponent createComponent() { return myMainPanel; } diff --git a/python/src/com/jetbrains/python/buildout/BuildoutFacetConfiguration.java b/python/src/com/jetbrains/python/buildout/BuildoutFacetConfiguration.java index 3bd48eb45a7a..7ae432113b5b 100644 --- a/python/src/com/jetbrains/python/buildout/BuildoutFacetConfiguration.java +++ b/python/src/com/jetbrains/python/buildout/BuildoutFacetConfiguration.java @@ -26,6 +26,7 @@ import com.intellij.openapi.util.JDOMExternalizerUtil; import com.intellij.openapi.util.WriteExternalException; import org.jdom.Element; import org.jetbrains.annotations.Nls; +import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; import javax.swing.*; @@ -102,6 +103,7 @@ public class BuildoutFacetConfiguration implements FacetConfiguration { return "Buildout"; } + @NotNull @Override public JComponent createComponent() { return myPanel;