From 921c35aedb766ac6d1a85eeb0e5c3155447179ea Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Fri, 28 Apr 2017 15:29:48 +0700 Subject: [PATCH] SuspiciousNameCombinationInspectionBase: exclude compare methods for boxed primitives --- .../SuspiciousNameCombinationInspectionBase.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/suspiciousNameCombination/SuspiciousNameCombinationInspectionBase.java b/java/java-analysis-impl/src/com/intellij/codeInspection/suspiciousNameCombination/SuspiciousNameCombinationInspectionBase.java index 885de8b25bf4..8257d1274303 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/suspiciousNameCombination/SuspiciousNameCombinationInspectionBase.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/suspiciousNameCombination/SuspiciousNameCombinationInspectionBase.java @@ -48,6 +48,13 @@ public class SuspiciousNameCombinationInspectionBase extends BaseJavaBatchLocalI .add("java.sql.PreparedStatement", "set.*") .add("java.sql.ResultSet", "update.*") .add("java.sql.SQLOutput", "write.*") + // parameters for compare methods are x and y which is also unrelated to coordinates + .add("java.lang.Integer", "compare.*") + .add("java.lang.Long", "compare.*") + .add("java.lang.Short", "compare") + .add("java.lang.Byte", "compare") + .add("java.lang.Character", "compare") + .add("java.lang.Boolean", "compare") // parameter names for addExact, multiplyFull, floorDiv, hypot etc. are x and y, // but either unlikely to be related to coordinates or their order does not matter (like in hypot) .add("java.lang.Math", ".*")