From 9150b2c2d881d08c8743153e306a5886ed7d6bae Mon Sep 17 00:00:00 2001 From: Nikolay Rykunov Date: Wed, 9 Oct 2024 16:41:19 +0200 Subject: [PATCH] [debugger-rd] IJPL-160146: Update todos -- add issue id GitOrigin-RevId: f1edfddf9e4d156f262b1e00584e0ec9e1b763eb --- .../backend/BackendXDebuggerEvaluatorApi.kt | 22 +++++++++---------- .../impl/frontend/FrontendXDebuggerManager.kt | 4 ++-- .../quick/FrontendXDebuggerEvaluator.kt | 2 +- .../frontend/evaluate/quick/FrontendXValue.kt | 2 +- .../evaluate/quick/XQuickEvaluateHandler.kt | 4 ++-- .../impl/rpc/XDebuggerEvaluatorApi.kt | 4 ++-- 6 files changed, 19 insertions(+), 19 deletions(-) diff --git a/platform/xdebugger-impl/backend/src/com/intellij/platform/debugger/impl/backend/BackendXDebuggerEvaluatorApi.kt b/platform/xdebugger-impl/backend/src/com/intellij/platform/debugger/impl/backend/BackendXDebuggerEvaluatorApi.kt index 0a761ef1b1a4..54b51aca8fb0 100644 --- a/platform/xdebugger-impl/backend/src/com/intellij/platform/debugger/impl/backend/BackendXDebuggerEvaluatorApi.kt +++ b/platform/xdebugger-impl/backend/src/com/intellij/platform/debugger/impl/backend/BackendXDebuggerEvaluatorApi.kt @@ -32,7 +32,7 @@ internal class BackendXDebuggerEvaluatorApi : XDebuggerEvaluatorApi { val evaluationResult = CompletableDeferred() withContext(Dispatchers.EDT) { - // TODO: pass XSourcePosition + // TODO[IJPL-160146]: pass XSourcePosition evaluator.evaluate(expression, object : XEvaluationCallback { override fun evaluated(result: XValue) { evaluationResult.complete(result) @@ -55,7 +55,7 @@ internal class BackendXDebuggerEvaluatorApi : XDebuggerEvaluatorApi { } val xValueEntity = withKernel { change { - // TODO: leaked XValue entity, it is never disposed + // TODO[IJPL-160146]: leaked XValue entity, it is never disposed LocalHintXValueEntity.new { it[LocalHintXValueEntity.Project] = evaluatorEntity.sessionEntity.projectEntity it[LocalHintXValueEntity.XValue] = xValue @@ -81,22 +81,22 @@ internal class BackendXDebuggerEvaluatorApi : XDebuggerEvaluatorApi { } override fun setPresentation(icon: Icon?, type: @NonNls String?, value: @NonNls String, hasChildren: Boolean) { - // TODO: pass icon, type and hasChildren too + // TODO[IJPL-160146]: pass icon, type and hasChildren too presentations.trySend(XValuePresentation(value, hasChildren)) } override fun setPresentation(icon: Icon?, presentation: com.intellij.xdebugger.frame.presentation.XValuePresentation, hasChildren: Boolean) { - // TODO: handle XValuePresentation fully + // TODO[IJPL-160146]: handle XValuePresentation fully val textExtractor = XValuePresentationTextExtractor() presentation.renderValue(textExtractor) setPresentation(icon, presentation.type, textExtractor.text, hasChildren) } override fun setFullValueEvaluator(fullValueEvaluator: XFullValueEvaluator) { - // TODO: implement setFullValueEvaluator + // TODO[IJPL-160146]: implement setFullValueEvaluator } } - // TODO: pass XValuePlace + // TODO[IJPL-160146]: pass XValuePlace xValue.computePresentation(valueNode, XValuePlace.TOOLTIP) launch { @@ -148,23 +148,23 @@ internal class BackendXDebuggerEvaluatorApi : XDebuggerEvaluatorApi { } override fun tooManyChildren(remaining: Int) { - // TODO: implement tooManyChildren + // TODO[IJPL-160146]: implement tooManyChildren } override fun setAlreadySorted(alreadySorted: Boolean) { - // TODO: implement setAlreadySorted + // TODO[IJPL-160146]: implement setAlreadySorted } override fun setErrorMessage(errorMessage: String) { - // TODO: implement setErrorMessage + // TODO[IJPL-160146]: implement setErrorMessage } override fun setErrorMessage(errorMessage: String, link: XDebuggerTreeNodeHyperlink?) { - // TODO: implement setErrorMessage + // TODO[IJPL-160146]: implement setErrorMessage } override fun setMessage(message: String, icon: Icon?, attributes: SimpleTextAttributes, link: XDebuggerTreeNodeHyperlink?) { - // TODO: implement setMessage + // TODO[IJPL-160146]: implement setMessage } } diff --git a/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/FrontendXDebuggerManager.kt b/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/FrontendXDebuggerManager.kt index 66df8cba906f..609cb6f15bd1 100644 --- a/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/FrontendXDebuggerManager.kt +++ b/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/FrontendXDebuggerManager.kt @@ -34,7 +34,7 @@ internal class FrontendXDebuggerManager(private val project: Project, private va .map { token -> sessionCoroutineScope?.cancel() if (token.added) { - // TODO: Service coroutine scope should contain Rete by default + // TODO[IJPL-160146]: Service coroutine scope should contain Rete by default val newSessionCoroutineScope = cs.childScope("FrontendXDebuggerSession") + KernelService.instance.kernelCoroutineScope.getCompleted().coroutineContext.kernelCoroutineContext() sessionCoroutineScope = newSessionCoroutineScope FrontendXDebuggerSession(newSessionCoroutineScope, token.value) @@ -44,7 +44,7 @@ internal class FrontendXDebuggerManager(private val project: Project, private va null } } - // TODO: Service coroutine scope should contain Rete by default + // TODO[IJPL-160146]: Service coroutine scope should contain Rete by default .stateIn(cs + KernelService.instance.kernelCoroutineScope.getCompleted().coroutineContext.kernelCoroutineContext(), SharingStarted.Eagerly, null) companion object { diff --git a/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/FrontendXDebuggerEvaluator.kt b/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/FrontendXDebuggerEvaluator.kt index db810d6e91d4..f01fe6adbcf0 100644 --- a/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/FrontendXDebuggerEvaluator.kt +++ b/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/FrontendXDebuggerEvaluator.kt @@ -16,7 +16,7 @@ import kotlinx.coroutines.launch private val LOG = logger() -// TODO: support XDebuggerPsiEvaluator +// TODO[IJPL-160146]: support XDebuggerPsiEvaluator internal class FrontendXDebuggerEvaluator(private val scope: CoroutineScope, private val evaluatorId: XDebuggerEvaluatorId) : XDebuggerEvaluator() { override fun evaluate(expression: String, callback: XEvaluationCallback, expressionPosition: XSourcePosition?) { scope.launch(Dispatchers.EDT) { diff --git a/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/FrontendXValue.kt b/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/FrontendXValue.kt index 36219bed2ff4..3ca3a42f080d 100644 --- a/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/FrontendXValue.kt +++ b/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/FrontendXValue.kt @@ -19,7 +19,7 @@ internal class FrontendXValue(private val xValueId: XValueId) : XValue() { override fun computePresentation(node: XValueNode, place: XValuePlace) { node.childCoroutineScope("FrontendXValue#computePresentation").launch(Dispatchers.EDT) { XDebuggerEvaluatorApi.getInstance().computePresentation(xValueId)?.collect { presentation -> - // TODO: pass proper params + // TODO[IJPL-160146]: pass proper params node.setPresentation(null, null, presentation.value, presentation.hasChildren) } } diff --git a/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/XQuickEvaluateHandler.kt b/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/XQuickEvaluateHandler.kt index d2588824656d..1c0c906b6558 100644 --- a/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/XQuickEvaluateHandler.kt +++ b/platform/xdebugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/evaluate/quick/XQuickEvaluateHandler.kt @@ -70,13 +70,13 @@ internal class XQuickEvaluateHandler : QuickEvaluateHandler() { } if (Registry.`is`("debugger.valueLookupFrontendBackend")) { val frontendEvaluator = FrontendXDebuggerManager.getInstance(project).currentSession.value?.evaluator?.value ?: return@async null - // TODO: provider proper editorsProvider + // TODO[IJPL-160146]: provide proper editorsProvider val editorsProvider = object : XDebuggerEditorsProvider() { override fun getFileType(): FileType { return FileTypes.PLAIN_TEXT } } - // TODO: support passing session: basically valueMarkers and currentPosition + // TODO[IJPL-160146]: support passing session: basically valueMarkers and currentPosition XValueHint(project, editorsProvider, editor, point, type, expressionInfo, frontendEvaluator, false) } else if (FrontendApplicationInfo.getFrontendType() is FrontendType.RemoteDev) { diff --git a/platform/xdebugger-impl/src/com/intellij/xdebugger/impl/rpc/XDebuggerEvaluatorApi.kt b/platform/xdebugger-impl/src/com/intellij/xdebugger/impl/rpc/XDebuggerEvaluatorApi.kt index 410f12b6ca53..0117e2d3db50 100644 --- a/platform/xdebugger-impl/src/com/intellij/xdebugger/impl/rpc/XDebuggerEvaluatorApi.kt +++ b/platform/xdebugger-impl/src/com/intellij/xdebugger/impl/rpc/XDebuggerEvaluatorApi.kt @@ -32,11 +32,11 @@ interface XDebuggerEvaluatorApi : RemoteApi { } } -// TODO: support other events see [com.intellij.xdebugger.frame.XCompositeNode] +// TODO[IJPL-160146]: support other events see [com.intellij.xdebugger.frame.XCompositeNode] @ApiStatus.Internal @Serializable sealed interface XValueComputeChildrenEvent { - // TODO: support [XValueGroup] + // TODO[IJPL-160146]: support [XValueGroup] @Serializable data class AddChildren(val names: List, val children: List, val isLast: Boolean) : XValueComputeChildrenEvent }