From 90369b34dcee3b13c25140d1767fcd6b3340edc4 Mon Sep 17 00:00:00 2001
From: marcelhillesheim <marcelhillesheim3@web.de>
Date: Fri, 15 Oct 2021 16:27:46 +0200
Subject: [PATCH] Added tests for existing inspections

GitOrigin-RevId: a296390121a24397e7568709f2bdd8aa47bcc716
---
 .../inspections/DuplicateKeyInspection.java   |  8 ++++
 .../SpaceInsideNonQuotedInspection.java       |  7 +++
 .../src/main/resources/META-INF/plugin.xml    |  2 +
 .../dotenv/tests/dotenv/InspectionsTest.java  | 44 +++++++++++++++++++
 .../tests/dotenv/fixtures/inspections.env     |  4 ++
 5 files changed, 65 insertions(+)
 create mode 100644 plugins/env-files-support/src/test/java/ru/adelf/idea/dotenv/tests/dotenv/InspectionsTest.java
 create mode 100644 plugins/env-files-support/src/test/java/ru/adelf/idea/dotenv/tests/dotenv/fixtures/inspections.env

diff --git a/plugins/env-files-support/src/main/java/ru/adelf/idea/dotenv/inspections/DuplicateKeyInspection.java b/plugins/env-files-support/src/main/java/ru/adelf/idea/dotenv/inspections/DuplicateKeyInspection.java
index 5acc7753ee2e..0faead0b4c81 100644
--- a/plugins/env-files-support/src/main/java/ru/adelf/idea/dotenv/inspections/DuplicateKeyInspection.java
+++ b/plugins/env-files-support/src/main/java/ru/adelf/idea/dotenv/inspections/DuplicateKeyInspection.java
@@ -15,6 +15,14 @@ import ru.adelf.idea.dotenv.psi.DotEnvFile;
 import java.util.*;
 
 public class DuplicateKeyInspection extends LocalInspectionTool {
+    // Change the display name within the plugin.xml
+    // This needs to be here as otherwise the tests will throw errors.
+    @NotNull
+    @Override
+    public String getDisplayName() {
+        return "Duplicate Key";
+    }
+
     @Override
     public boolean runForWholeFile() {
         return true;
diff --git a/plugins/env-files-support/src/main/java/ru/adelf/idea/dotenv/inspections/SpaceInsideNonQuotedInspection.java b/plugins/env-files-support/src/main/java/ru/adelf/idea/dotenv/inspections/SpaceInsideNonQuotedInspection.java
index 65d37553e128..bfaae7f21ba3 100644
--- a/plugins/env-files-support/src/main/java/ru/adelf/idea/dotenv/inspections/SpaceInsideNonQuotedInspection.java
+++ b/plugins/env-files-support/src/main/java/ru/adelf/idea/dotenv/inspections/SpaceInsideNonQuotedInspection.java
@@ -16,6 +16,13 @@ import ru.adelf.idea.dotenv.psi.DotEnvTypes;
 import ru.adelf.idea.dotenv.psi.DotEnvValue;
 
 public class SpaceInsideNonQuotedInspection extends LocalInspectionTool {
+    // Change the display name within the plugin.xml
+    // This needs to be here as otherwise the tests will throw errors.
+    @NotNull
+    @Override
+    public String getDisplayName() {
+        return "Space inside non-quoted value";
+    }
 
     private AddQuotesQuickFix addQuotesQuickFix = new AddQuotesQuickFix();
 
diff --git a/plugins/env-files-support/src/main/resources/META-INF/plugin.xml b/plugins/env-files-support/src/main/resources/META-INF/plugin.xml
index c7cdbcc721ec..f7b45129b415 100644
--- a/plugins/env-files-support/src/main/resources/META-INF/plugin.xml
+++ b/plugins/env-files-support/src/main/resources/META-INF/plugin.xml
@@ -86,6 +86,7 @@
         <lang.parserDefinition language="DotEnv" implementationClass="ru.adelf.idea.dotenv.DotEnvParserDefinition"/>
         <lang.commenter language="DotEnv" implementationClass="ru.adelf.idea.dotenv.extension.DotEnvCommenter"/>
 
+        <!-- displayName defined within class otherwise test will throw errors -->
         <localInspection language="DotEnv"
                          groupName="DotEnv"
                          shortName="DotEnvDuplicateKeyInspection"
@@ -94,6 +95,7 @@
                          level="WARNING"
                          implementationClass="ru.adelf.idea.dotenv.inspections.DuplicateKeyInspection"/>
 
+        <!-- displayName defined within class otherwise test will throw errors -->
         <localInspection language="DotEnv"
                          groupName="DotEnv"
                          shortName="DotEnvSpaceInsideNonQuotedInspection"
diff --git a/plugins/env-files-support/src/test/java/ru/adelf/idea/dotenv/tests/dotenv/InspectionsTest.java b/plugins/env-files-support/src/test/java/ru/adelf/idea/dotenv/tests/dotenv/InspectionsTest.java
new file mode 100644
index 000000000000..fe5366cad342
--- /dev/null
+++ b/plugins/env-files-support/src/test/java/ru/adelf/idea/dotenv/tests/dotenv/InspectionsTest.java
@@ -0,0 +1,44 @@
+package ru.adelf.idea.dotenv.tests.dotenv;
+
+import com.intellij.codeInsight.daemon.impl.HighlightInfo;
+import com.intellij.codeInspection.InspectionProfileEntry;
+import ru.adelf.idea.dotenv.inspections.DuplicateKeyInspection;
+import ru.adelf.idea.dotenv.inspections.SpaceInsideNonQuotedInspection;
+import ru.adelf.idea.dotenv.tests.DotEnvLightCodeInsightFixtureTestCase;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+
+public class InspectionsTest extends DotEnvLightCodeInsightFixtureTestCase {
+
+    @Override
+    public void setUp() throws Exception {
+        super.setUp();
+        myFixture.configureFromExistingVirtualFile(myFixture.copyFileToProject("inspections.env"));
+    }
+
+    protected String getTestDataPath() {
+        return basePath + "dotenv/fixtures";
+    }
+
+    public void testDuplicateKey() {
+        doInspectionTest(new DuplicateKeyInspection(), Arrays.asList("DUPLICATE_KEY=test", "DUPLICATE_KEY=test2"));
+    }
+
+    public void testSpaceInsideNonQuoted() {
+        doInspectionTest(new SpaceInsideNonQuotedInspection(), Collections.singletonList("spaces without quotes"));
+    }
+
+    private void doInspectionTest(InspectionProfileEntry entry, List<String> expectedHighlightedText) {
+        myFixture.enableInspections(entry);
+
+        List<HighlightInfo> highlightInfoList = myFixture.doHighlighting();
+        List<String> actualHighlightedText = new ArrayList<>();
+
+        highlightInfoList.forEach( highlightInfo -> actualHighlightedText.add(highlightInfo.getText()));
+
+        assertEquals(actualHighlightedText, expectedHighlightedText);
+    }
+}
diff --git a/plugins/env-files-support/src/test/java/ru/adelf/idea/dotenv/tests/dotenv/fixtures/inspections.env b/plugins/env-files-support/src/test/java/ru/adelf/idea/dotenv/tests/dotenv/fixtures/inspections.env
new file mode 100644
index 000000000000..fd56b7ffbec4
--- /dev/null
+++ b/plugins/env-files-support/src/test/java/ru/adelf/idea/dotenv/tests/dotenv/fixtures/inspections.env
@@ -0,0 +1,4 @@
+DUPLICATE_KEY=test
+DUPLICATE_KEY=test2
+
+SPACE_INSIDE_NON_QUOTED=spaces without quotes