From 8ddeb3ec76def7225836f8af4ec3a9ef44100c1d Mon Sep 17 00:00:00 2001
From: Anna Kozlova <anna.kozlova@jetbrains.com>
Date: Wed, 6 May 2020 09:20:02 +0200
Subject: [PATCH] java redundant cast: cleanup: simplify warning registering

GitOrigin-RevId: c04868bf236d1750cec6cc7546e1e3ea840a7d25
---
 .../com/intellij/psi/util/RedundantCastUtil.java | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/java/java-analysis-impl/src/com/intellij/psi/util/RedundantCastUtil.java b/java/java-analysis-impl/src/com/intellij/psi/util/RedundantCastUtil.java
index 03b8a9897b86..55964e63111b 100644
--- a/java/java-analysis-impl/src/com/intellij/psi/util/RedundantCastUtil.java
+++ b/java/java-analysis-impl/src/com/intellij/psi/util/RedundantCastUtil.java
@@ -76,10 +76,8 @@ public class RedundantCastUtil {
     }
 
     @Override
-    protected void addToResults(@NotNull PsiTypeCastExpression typeCast) {
-      if (!isTypeCastSemantic(typeCast)) {
-        myFoundCasts.add(typeCast);
-      }
+    protected void registerCast(@NotNull PsiTypeCastExpression typeCast) {
+      myFoundCasts.add(typeCast);
     }
   }
 
@@ -87,13 +85,17 @@ public class RedundantCastUtil {
   private static class MyIsRedundantVisitor extends JavaRecursiveElementWalkingVisitor {
     private PsiTypeCastExpression foundRedundantCast;
 
-    protected void addToResults(@NotNull PsiTypeCastExpression typeCast){
+    private void addToResults(@NotNull PsiTypeCastExpression typeCast){
       if (!isTypeCastSemantic(typeCast)) {
-        foundRedundantCast = typeCast;
-        stopWalking();
+        registerCast(typeCast);
       }
     }
 
+    protected void registerCast(@NotNull PsiTypeCastExpression typeCast) {
+      foundRedundantCast = typeCast;
+      stopWalking();
+    }
+
     @Override public void visitAssignmentExpression(PsiAssignmentExpression expression) {
       processPossibleTypeCast(expression.getRExpression(), expression.getLExpression().getType());
       super.visitAssignmentExpression(expression);