From 8d382f359cb884f00e8e7194e57b6031428260e4 Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Mon, 4 Dec 2017 12:19:14 +0700 Subject: [PATCH] RedundantCollectionOperation: example in description, cosmetic fixes Review ID: IDEA-CR-27215 --- .../RedundantCollectionOperation.html | 5 ++++- .../redundancy/RedundantCollectionOperationInspection.java | 7 ++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/java/java-impl/src/inspectionDescriptions/RedundantCollectionOperation.html b/java/java-impl/src/inspectionDescriptions/RedundantCollectionOperation.html index 12efec8f6424..18899e648a67 100644 --- a/java/java-impl/src/inspectionDescriptions/RedundantCollectionOperation.html +++ b/java/java-impl/src/inspectionDescriptions/RedundantCollectionOperation.html @@ -1,6 +1,9 @@ -Reports unnecessarily complex collection operations which have simpler alternatives. +Reports unnecessarily complex collection operations which have simpler alternatives. E.g. +Arrays.asList(array).subList(0, 10).toArray(new String[0]) could be simplified to +Arrays.copyOfRange(array, 0, 10) or collection.containsAll(singletonList("x")) could be +simplified to collection.contains("x").

New in 2018.1

diff --git a/plugins/InspectionGadgets/src/com/siyeh/ig/redundancy/RedundantCollectionOperationInspection.java b/plugins/InspectionGadgets/src/com/siyeh/ig/redundancy/RedundantCollectionOperationInspection.java index f06ff4eca89f..777b3c4cdbb7 100644 --- a/plugins/InspectionGadgets/src/com/siyeh/ig/redundancy/RedundantCollectionOperationInspection.java +++ b/plugins/InspectionGadgets/src/com/siyeh/ig/redundancy/RedundantCollectionOperationInspection.java @@ -245,10 +245,11 @@ public class RedundantCollectionOperationInspection extends AbstractBaseJavaLoca } private static class RedundantCollectionOperationFix implements LocalQuickFix { - private RedundantCollectionOperationHandler myHandler; + private final RedundantCollectionOperationHandler myHandler; - public RedundantCollectionOperationFix( - RedundantCollectionOperationHandler handler) {myHandler = handler;} + public RedundantCollectionOperationFix(RedundantCollectionOperationHandler handler) { + myHandler = handler; + } @Nls @NotNull