diff --git a/build/dependencies/buildSrc/buildSrc.iml b/build/dependencies/buildSrc/buildSrc.iml
index bac8a4f1f063..f194e8000d0f 100644
--- a/build/dependencies/buildSrc/buildSrc.iml
+++ b/build/dependencies/buildSrc/buildSrc.iml
@@ -23,6 +23,15 @@
+
+
+
+
+
+
+
+
+
@@ -34,14 +43,5 @@
-
-
-
-
-
-
-
-
-
\ No newline at end of file
diff --git a/platform/external-system-impl/src/com/intellij/openapi/externalSystem/service/project/manage/AbstractModuleDataService.java b/platform/external-system-impl/src/com/intellij/openapi/externalSystem/service/project/manage/AbstractModuleDataService.java
index 9fabeff65b72..9f56d1c16b97 100644
--- a/platform/external-system-impl/src/com/intellij/openapi/externalSystem/service/project/manage/AbstractModuleDataService.java
+++ b/platform/external-system-impl/src/com/intellij/openapi/externalSystem/service/project/manage/AbstractModuleDataService.java
@@ -79,7 +79,7 @@ public abstract class AbstractModuleDataService extends Ab
return;
}
- final Collection> toCreate = filterExistingModules(toImport, modelsProvider, project);
+ final Collection> toCreate = filterExistingModules(toImport, modelsProvider);
if (!toCreate.isEmpty()) {
createModules(toCreate, modelsProvider, project);
}
@@ -145,8 +145,7 @@ public abstract class AbstractModuleDataService extends Ab
@NotNull
private Collection> filterExistingModules(@NotNull Collection> modules,
- @NotNull IdeModifiableModelsProvider modelsProvider,
- @NotNull Project project) {
+ @NotNull IdeModifiableModelsProvider modelsProvider) {
Collection> result = ContainerUtilRt.newArrayList();
for (DataNode node : modules) {
ModuleData moduleData = node.getData();
@@ -257,7 +256,6 @@ public abstract class AbstractModuleDataService extends Ab
init();
}
- @Nullable
@Override
protected JComponent createCenterPanel() {
return new JBScrollPane(content);
@@ -381,7 +379,7 @@ public abstract class AbstractModuleDataService extends Ab
}
if (LOG.isDebugEnabled()) {
- final boolean changed = !ArrayUtil.equals(orderEntries, newOrder, (Comparator)(o1, o2) -> o1.compareTo(o2));
+ final boolean changed = !ArrayUtil.equals(orderEntries, newOrder, Comparator.naturalOrder());
LOG.debug(String.format("rearrange status (%s): %s", modifiableRootModel.getModule(), changed ? "modified" : "not modified"));
}
modifiableRootModel.rearrangeOrderEntries(newOrder);
@@ -398,7 +396,7 @@ public abstract class AbstractModuleDataService extends Ab
idx--;
}
}
- return idx == -1 ? -1 : idx;
+ return idx;
}
private void setLanguageLevel(@NotNull ModifiableRootModel modifiableRootModel, E data) {
diff --git a/plugins/gradle/src/org/jetbrains/plugins/gradle/service/project/BaseGradleProjectResolverExtension.java b/plugins/gradle/src/org/jetbrains/plugins/gradle/service/project/BaseGradleProjectResolverExtension.java
index 847bfba8139a..9dc176e35e94 100644
--- a/plugins/gradle/src/org/jetbrains/plugins/gradle/service/project/BaseGradleProjectResolverExtension.java
+++ b/plugins/gradle/src/org/jetbrains/plugins/gradle/service/project/BaseGradleProjectResolverExtension.java
@@ -473,7 +473,8 @@ public class BaseGradleProjectResolverExtension implements GradleProjectResolver
if (dependencies == null) return;
List orphanModules = ContainerUtil.newArrayList();
- for (IdeaDependency dependency : dependencies) {
+ for (int i = 0; i < dependencies.size(); i++) {
+ IdeaDependency dependency = dependencies.get(i);
if (dependency == null) {
continue;
}
@@ -485,6 +486,7 @@ public class BaseGradleProjectResolverExtension implements GradleProjectResolver
if (scope != null) {
d.setScope(scope);
}
+ d.setOrder(i);
ideModule.createChild(ProjectKeys.MODULE_DEPENDENCY, d);
ModuleData targetModule = d.getTarget();
if (targetModule.getId().isEmpty() && targetModule.getLinkedExternalProjectPath().isEmpty()) {
@@ -497,6 +499,7 @@ public class BaseGradleProjectResolverExtension implements GradleProjectResolver
if (scope != null) {
d.setScope(scope);
}
+ d.setOrder(i);
ideModule.createChild(ProjectKeys.LIBRARY_DEPENDENCY, d);
}
}