From 88d4c3d6fbbb1f166523d718113d8ef2b50fbb8b Mon Sep 17 00:00:00 2001 From: anna Date: Mon, 22 Aug 2011 11:55:26 +0200 Subject: [PATCH] disable add static import intention for classes in default package (->IDEA-26971 ) --- .../intention/impl/AddOnDemandStaticImportAction.java | 3 +++ .../intention/impl/AddSingleMemberStaticImportAction.java | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/java/java-impl/src/com/intellij/codeInsight/intention/impl/AddOnDemandStaticImportAction.java b/java/java-impl/src/com/intellij/codeInsight/intention/impl/AddOnDemandStaticImportAction.java index efe0b105545e..645d5b0b29fc 100644 --- a/java/java-impl/src/com/intellij/codeInsight/intention/impl/AddOnDemandStaticImportAction.java +++ b/java/java-impl/src/com/intellij/codeInsight/intention/impl/AddOnDemandStaticImportAction.java @@ -24,6 +24,8 @@ import com.intellij.openapi.editor.Editor; import com.intellij.openapi.editor.colors.EditorColors; import com.intellij.openapi.editor.colors.EditorColorsManager; import com.intellij.openapi.project.Project; +import com.intellij.openapi.util.Comparing; +import com.intellij.openapi.util.text.StringUtil; import com.intellij.psi.*; import com.intellij.psi.util.PsiTreeUtil; import com.intellij.psi.util.PsiUtil; @@ -65,6 +67,7 @@ public class AddOnDemandStaticImportAction extends PsiElementBaseIntentionAction return null; } PsiClass psiClass = (PsiClass)resolved; + if (Comparing.strEqual(psiClass.getName(), psiClass.getQualifiedName())) return null; PsiFile file = refExpr.getContainingFile(); if (!(file instanceof PsiJavaFile)) return null; PsiImportList importList = ((PsiJavaFile)file).getImportList(); diff --git a/java/java-impl/src/com/intellij/codeInsight/intention/impl/AddSingleMemberStaticImportAction.java b/java/java-impl/src/com/intellij/codeInsight/intention/impl/AddSingleMemberStaticImportAction.java index 87b3b2046ee5..190e54faf35f 100644 --- a/java/java-impl/src/com/intellij/codeInsight/intention/impl/AddSingleMemberStaticImportAction.java +++ b/java/java-impl/src/com/intellij/codeInsight/intention/impl/AddSingleMemberStaticImportAction.java @@ -25,7 +25,9 @@ import com.intellij.codeInsight.intention.PsiElementBaseIntentionAction; import com.intellij.openapi.diagnostic.Logger; import com.intellij.openapi.editor.Editor; import com.intellij.openapi.project.Project; +import com.intellij.openapi.util.Comparing; import com.intellij.openapi.util.Key; +import com.intellij.openapi.util.text.StringUtil; import com.intellij.psi.*; import com.intellij.psi.util.PsiTreeUtil; import com.intellij.psi.util.PsiUtil; @@ -63,7 +65,7 @@ public class AddSingleMemberStaticImportAction extends PsiElementBaseIntentionAc PsiClass aClass = ((PsiMember)resolved).getContainingClass(); if (aClass != null && !PsiTreeUtil.isAncestor(aClass, element, true)) { String qName = aClass.getQualifiedName(); - if (qName != null) { + if (qName != null && !Comparing.strEqual(qName, aClass.getName())) { qName = qName + "." +refExpr.getReferenceName(); if (file instanceof PsiJavaFile) { PsiImportList importList = ((PsiJavaFile)file).getImportList();