diff --git a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/CreateConstructorMatchingSuperFix.java b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/CreateConstructorMatchingSuperFix.java index 5bc69199b93c..59fb97bb44d1 100644 --- a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/CreateConstructorMatchingSuperFix.java +++ b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/CreateConstructorMatchingSuperFix.java @@ -29,6 +29,7 @@ import com.intellij.openapi.editor.ScrollType; import com.intellij.openapi.project.Project; import com.intellij.psi.*; import com.intellij.psi.codeStyle.CodeStyleManager; +import com.intellij.psi.codeStyle.JavaCodeStyleManager; import com.intellij.psi.javadoc.PsiDocComment; import com.intellij.psi.util.PsiUtil; import com.intellij.psi.util.TypeConversionUtil; @@ -147,7 +148,8 @@ public class CreateConstructorMatchingSuperFix extends BaseIntentionAction { derived.getBody().replace(stub.getBody()); derived = (PsiMethod)reformatter.reformat(derived); - derived = (PsiMethod)targetClass.add(derived); + derived = (PsiMethod)JavaCodeStyleManager.getInstance(project).shortenClassReferences(derived); + derived = (PsiMethod)GenerateMembersUtil.insert(targetClass, derived, null, true); } if (derived != null) { editor.getCaretModel().moveToOffset(derived.getTextRange().getStartOffset()); diff --git a/java/java-impl/src/com/intellij/refactoring/introduceVariable/JavaVariableInplaceIntroducer.java b/java/java-impl/src/com/intellij/refactoring/introduceVariable/JavaVariableInplaceIntroducer.java index d9d0dc41135a..25f01b4fd8dd 100644 --- a/java/java-impl/src/com/intellij/refactoring/introduceVariable/JavaVariableInplaceIntroducer.java +++ b/java/java-impl/src/com/intellij/refactoring/introduceVariable/JavaVariableInplaceIntroducer.java @@ -194,7 +194,7 @@ public class JavaVariableInplaceIntroducer extends InplaceVariableIntroducer extends In releaseIfNotRestart(); } }); + myEditor.getScrollingModel().scrollToCaret(ScrollType.MAKE_VISIBLE); myBalloon.show(new PositionTracker(myEditor.getContentComponent()) { @Override public RelativePoint recalculateLocation(Balloon object) { diff --git a/platform/platform-impl/src/com/intellij/ide/IdeTooltip.java b/platform/platform-impl/src/com/intellij/ide/IdeTooltip.java index fea6906a3b9f..59511366ce00 100644 --- a/platform/platform-impl/src/com/intellij/ide/IdeTooltip.java +++ b/platform/platform-impl/src/com/intellij/ide/IdeTooltip.java @@ -50,6 +50,8 @@ public class IdeTooltip extends ComparableObject.Impl { private Ui myUi; + private boolean hint = false; + public IdeTooltip(Component component, Point point, JComponent tipComponent, Object... identity) { super(identity); @@ -232,6 +234,15 @@ public class IdeTooltip extends ComparableObject.Impl { return myLayer; } + public IdeTooltip setHint(boolean hint) { + this.hint = hint; + return this; + } + + public boolean isHint() { + return hint; + } + public boolean isInside(RelativePoint target) { return myUi != null && myUi.isInside(target); } diff --git a/platform/platform-impl/src/com/intellij/ide/IdeTooltipManager.java b/platform/platform-impl/src/com/intellij/ide/IdeTooltipManager.java index 61aaca2999b7..ecfc7331e470 100644 --- a/platform/platform-impl/src/com/intellij/ide/IdeTooltipManager.java +++ b/platform/platform-impl/src/com/intellij/ide/IdeTooltipManager.java @@ -143,7 +143,12 @@ public class IdeTooltipManager implements ApplicationComponent, AWTEventListener if (!myCurrentTipIsCentered) { myX = me.getX(); myY = me.getY(); - maybeShowFor(c, me); + if (c instanceof JComponent && ((JComponent)c).getToolTipText(me) == null && (myQueuedTooltip == null || !myQueuedTooltip.isHint())) { + hideCurrent(me, null, null);//There is no tooltip or hint here, let's proceed it as MOUSE_EXITED + } + else { + maybeShowFor(c, me); + } } } } diff --git a/platform/platform-impl/src/com/intellij/ui/LightweightHint.java b/platform/platform-impl/src/com/intellij/ui/LightweightHint.java index 56acf0a9cc90..0f09b4ec66dc 100644 --- a/platform/platform-impl/src/com/intellij/ui/LightweightHint.java +++ b/platform/platform-impl/src/com/intellij/ui/LightweightHint.java @@ -166,8 +166,8 @@ public class LightweightHint extends UserDataHolderBase implements Hint { .setFont(hintHint.getTextFont()) .setCalloutShift(hintHint.getCalloutShift()) .setPositionChangeShift(hintHint.getPositionChangeX(), hintHint.getPositionChangeY()) - .setExplicitClose(hintHint.isExplicitClose()); - + .setExplicitClose(hintHint.isExplicitClose()) + .setHint(true); myComponent.validate(); myCurrentIdeTooltip = IdeTooltipManager.getInstance().show(tooltip, hintHint.isShowImmediately()); } else { diff --git a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/RemoteRevisionsNumbersCache.java b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/RemoteRevisionsNumbersCache.java index a548c323ee91..193d994f90e3 100644 --- a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/RemoteRevisionsNumbersCache.java +++ b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/RemoteRevisionsNumbersCache.java @@ -301,7 +301,7 @@ public class RemoteRevisionsNumbersCache implements ChangesOnServerTracker { if ((NOT_LOADED == remote) || (UNKNOWN == remote)) { return true; } - return local.compareTo(remote) == 0; + return local.compareTo(remote) >= 0; } return true; }