From 86a870ca04a22fc8848d750d40e2f26422efa3f8 Mon Sep 17 00:00:00 2001 From: "Ilia.Shulgin" Date: Wed, 24 Sep 2025 14:08:32 +0200 Subject: [PATCH] [vcs] IJPL-173924 Get rid of ChangesViewI#setBusy GitOrigin-RevId: 6728bbfd6bc5ab875486eba9abc55790941b39e5 --- platform/vcs-impl/api-dump.txt | 2 -- .../openapi/vcs/changes/BackendCommitChangesViewModel.kt | 8 -------- .../openapi/vcs/changes/ChangeListManagerImpl.java | 1 - .../com/intellij/openapi/vcs/changes/ChangesViewI.java | 1 - .../intellij/openapi/vcs/changes/ChangesViewManager.java | 6 ------ .../intellij/openapi/vcs/changes/DummyChangesView.java | 4 ---- 6 files changed, 22 deletions(-) diff --git a/platform/vcs-impl/api-dump.txt b/platform/vcs-impl/api-dump.txt index 910a1266e49a..fddc397e502d 100644 --- a/platform/vcs-impl/api-dump.txt +++ b/platform/vcs-impl/api-dump.txt @@ -781,7 +781,6 @@ com.intellij.openapi.vcs.changes.ChangesViewI - a:scheduleRefresh():V - a:selectChanges(java.util.List):V - a:selectFile(com.intellij.openapi.vfs.VirtualFile):V -- a:setBusy(Z):V - a:setGrouping(java.lang.String):V - a:updateProgressComponent(java.util.List):V c:com.intellij.openapi.vcs.changes.ChangesViewManager @@ -802,7 +801,6 @@ c:com.intellij.openapi.vcs.changes.ChangesViewManager - scheduleRefresh(java.lang.Runnable):V - selectChanges(java.util.List):V - selectFile(com.intellij.openapi.vfs.VirtualFile):V -- setBusy(Z):V - setGrouping(java.lang.String):V - updateProgressComponent(java.util.List):V f:com.intellij.openapi.vcs.changes.ChangesViewManager$ChangesViewToolWindowPanel diff --git a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/BackendCommitChangesViewModel.kt b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/BackendCommitChangesViewModel.kt index cce6646248ff..8d9735d49e11 100644 --- a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/BackendCommitChangesViewModel.kt +++ b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/BackendCommitChangesViewModel.kt @@ -69,7 +69,6 @@ internal interface BackendCommitChangesViewModel { fun getActions(): List fun isModelUpdateInProgress(): Boolean - fun setBusy(busy: Boolean) fun scheduleRefreshNow(callback: Runnable?) fun scheduleDelayedRefresh() fun setGrouping(groupingKey: String) @@ -107,9 +106,6 @@ private class BackendRemoteCommitChangesViewModel(private val project: Project) override fun isModelUpdateInProgress(): Boolean = false - override fun setBusy(busy: Boolean) { - } - override fun scheduleRefreshNow(callback: Runnable?) { } @@ -156,10 +152,6 @@ private class BackendLocalCommitChangesViewModel(private val panel: CommitChange override fun isModelUpdateInProgress(): Boolean = panel.changesView.isModelUpdateInProgress - override fun setBusy(busy: Boolean) { - panel.setBusy(busy) - } - override fun scheduleRefreshNow(callback: Runnable?) { panel.scheduleRefreshNow(callback) } diff --git a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangeListManagerImpl.java b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangeListManagerImpl.java index 00df025bb963..0f1b4d0e1dc8 100644 --- a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangeListManagerImpl.java +++ b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangeListManagerImpl.java @@ -525,7 +525,6 @@ public final class ChangeListManagerImpl extends ChangeListManagerEx implements isInitialUpdate = myInitialUpdate; myInitialUpdate = false; } - changesView.setBusy(true); changesView.scheduleRefresh(); SensitiveProgressWrapper vcsIndicator = new SensitiveProgressWrapper(ProgressManager.getInstance().getProgressIndicator()); diff --git a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangesViewI.java b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangesViewI.java index a346c1c66e26..2d8eef78d365 100644 --- a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangesViewI.java +++ b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangesViewI.java @@ -27,7 +27,6 @@ public interface ChangesViewI { void selectFile(VirtualFile vFile); void selectChanges(@NotNull List changes); void updateProgressComponent(@NotNull List> progress); - void setBusy(boolean b); void setGrouping(@NotNull String groupingKey); } diff --git a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangesViewManager.java b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangesViewManager.java index ebe884d9abbc..6469427fdd96 100644 --- a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangesViewManager.java +++ b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangesViewManager.java @@ -201,12 +201,6 @@ public class ChangesViewManager implements ChangesViewEx, Disposable { myToolWindowPanel.updateProgressComponent(progress); } - @Override - public void setBusy(boolean b) { - if (myChangesView == null) return; - myChangesView.getViewModel().setBusy(b); - } - @Override public void setGrouping(@NotNull String groupingKey) { if (myChangesView == null) return; diff --git a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/DummyChangesView.java b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/DummyChangesView.java index f1bc1734e2a7..176e5b2f1737 100644 --- a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/DummyChangesView.java +++ b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/DummyChangesView.java @@ -48,10 +48,6 @@ class DummyChangesView implements ChangesViewEx { public void updateProgressComponent(@NotNull List> progress) { } - @Override - public void setBusy(boolean b) { - } - @Override public void setGrouping(@NotNull String groupingKey) { }