From 8511dede3d2294c7e994136549c888911f91bcb2 Mon Sep 17 00:00:00 2001 From: "Dmitry.Krasilschikov" Date: Sun, 13 Oct 2019 00:20:28 +0300 Subject: [PATCH] IDEA-CR-53387 IDEA-223967 what's new notification: expire it on click and project open listeners optimization GitOrigin-RevId: 096b28a20e82f0decab9f31fbfd42bee6984d831 --- .../impl/UpdateCheckerComponent.java | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/UpdateCheckerComponent.java b/platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/UpdateCheckerComponent.java index 8efd33266916..1e4f8172ed25 100644 --- a/platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/UpdateCheckerComponent.java +++ b/platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/UpdateCheckerComponent.java @@ -65,20 +65,14 @@ public final class UpdateCheckerComponent implements Runnable { snapPackageNotification(); MessageBusConnection connection = app.getMessageBus().connect(); - if (!updateFailed) { - connection.subscribe(ProjectManager.TOPIC, new ProjectManagerListener() { - @Override - public void projectOpened(@NotNull Project project) { - StartupManager.getInstance(project).registerPostStartupActivity(() -> { showWhatsNewNotification(project); }); - } - }); - } - connection.subscribe(ProjectManager.TOPIC, new ProjectManagerListener() { @Override public void projectOpened(@NotNull Project project) { connection.disconnect(); - StartupManager.getInstance(project).registerPostStartupActivity(() -> UpdateInstaller.cleanupPatch()); + StartupManager.getInstance(project).registerPostStartupActivity(() -> { + if (!updateFailed) showWhatsNewNotification(project); + UpdateInstaller.cleanupPatch(); + }); } }); }); @@ -116,6 +110,7 @@ public final class UpdateCheckerComponent implements Runnable { file.putUserData(HTMLEditorProvider.Companion.getHTML_CONTENT_TYPE(), true); FileEditorManager.getInstance(project).openFile(file, true); IdeUpdateUsageTriggerCollector.trigger("update.whats.new"); + notification.expire(); } }); properties.setValue(UPDATE_WHATS_NEW_MESSAGE, null);