From 84a915c3f97fb4b9888cd527d8b30e584582acb8 Mon Sep 17 00:00:00 2001
From: "Alexander.Glukhov" <alexander.glukhov@jetbrains.com>
Date: Mon, 26 Jun 2023 13:52:31 +0200
Subject: [PATCH] [gradle] [IDEA-314169] forced IdeaPlugin settings override on
 project import if download sources flag value is not null

GitOrigin-RevId: b0709d34c896de0dfa7fb4cc782d4d5119b3dedd
---
 .../builder/ExternalProjectBuilderImpl.groovy | 26 ++++++++++++++++---
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/plugins/gradle/tooling-extension-impl/src/org/jetbrains/plugins/gradle/tooling/builder/ExternalProjectBuilderImpl.groovy b/plugins/gradle/tooling-extension-impl/src/org/jetbrains/plugins/gradle/tooling/builder/ExternalProjectBuilderImpl.groovy
index 44b8b5892708..ab8f8b09558b 100644
--- a/plugins/gradle/tooling-extension-impl/src/org/jetbrains/plugins/gradle/tooling/builder/ExternalProjectBuilderImpl.groovy
+++ b/plugins/gradle/tooling-extension-impl/src/org/jetbrains/plugins/gradle/tooling/builder/ExternalProjectBuilderImpl.groovy
@@ -238,8 +238,9 @@ class ExternalProjectBuilderImpl extends AbstractModelBuilderService {
     def ideaResourceDirs = null
     def ideaTestSourceDirs = null
     def ideaTestResourceDirs = null
-    def downloadJavadoc = false
-    def downloadSources = Boolean.parseBoolean(System.getProperty("idea.disable.gradle.download.sources", "true"))
+    def downloadSourcesFlag = System.getProperty("idea.disable.gradle.download.sources")
+    def downloadSources = downloadSourcesFlag == null ? true : Boolean.valueOf(downloadSourcesFlag)
+    def downloadJavadoc = downloadSourcesFlag == null ? false : downloadSources
 
     def testSourceSets = []
 
@@ -270,8 +271,25 @@ class ExternalProjectBuilderImpl extends AbstractModelBuilderService {
         ideaTestSourceDirs = new LinkedHashSet<>(ideaPluginModule.testSourceDirs)
         ideaTestResourceDirs = ideaPluginModule.hasProperty("testResourceDirs") ? new LinkedHashSet<>(ideaPluginModule.testResourceDirs) : []
       }
-      downloadJavadoc = ideaPluginModule.downloadJavadoc
-      downloadSources = ideaPluginModule.downloadSources
+      if (downloadSourcesFlag != null) {
+        ideaPluginModule.downloadSources = downloadSources
+        ideaPluginModule.downloadJavadoc = downloadJavadoc
+      }
+      else {
+        downloadJavadoc = ideaPluginModule.downloadJavadoc
+        downloadSources = ideaPluginModule.downloadSources
+      }
+    }
+    if (ideaPluginModule == null && downloadSourcesFlag != null) {
+      project.plugins.whenPluginAdded { plugin ->
+        if (plugin instanceof IdeaPlugin) {
+          def module = plugin?.model?.module
+          if (module != null) {
+            module.downloadJavadoc = downloadJavadoc
+            module.downloadSources = downloadSources
+          }
+        }
+      }
     }
 
     def projectSourceCompatibility = getSourceCompatibility(project)