From 8463c0a81bd2161ab946ad2ebf54b900f349b8bb Mon Sep 17 00:00:00 2001
From: Alexander Lobas <Alexander.Lobas@jetbrains.com>
Date: Mon, 18 Sep 2023 21:22:45 +0200
Subject: [PATCH] IDEA-331015 IDEA still suggests downloading a new version
 despite IDE update check being disabled

GitOrigin-RevId: 709532ab8a778b271e553f57da966407f6d05365
---
 ...pdateSettingsEntryPointActionProvider.java | 21 ++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/UpdateSettingsEntryPointActionProvider.java b/platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/UpdateSettingsEntryPointActionProvider.java
index 94bb86b5400e..afc1a5eb4898 100644
--- a/platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/UpdateSettingsEntryPointActionProvider.java
+++ b/platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/UpdateSettingsEntryPointActionProvider.java
@@ -58,6 +58,10 @@ final class UpdateSettingsEntryPointActionProvider implements ActionProvider {
   }
 
   private static void preparePrevPlatformUpdate() {
+    if (!UpdateSettings.getInstance().isCheckNeeded()) {
+      return;
+    }
+
     PropertiesComponent properties = PropertiesComponent.getInstance();
     BuildNumber newBuildForUpdate;
     try {
@@ -141,9 +145,15 @@ final class UpdateSettingsEntryPointActionProvider implements ActionProvider {
     if (settings.isCheckNeeded()) {
       setPlatformUpdateInfo(platformUpdateInfo);
     }
+    else {
+      setPlatformUpdateInfo(null);
+    }
     if (settings.isPluginsCheckNeeded()) {
       newPlatformUpdate(updatedPlugins, incompatiblePlugins, null);
     }
+    else {
+      newPlatformUpdate(null, null, (String)null);
+    }
     updateState();
   }
 
@@ -173,13 +183,18 @@ final class UpdateSettingsEntryPointActionProvider implements ActionProvider {
 
   public static void newPluginUpdates(@NotNull Collection<PluginDownloader> updatedPlugins,
                                       @NotNull Collection<PluginNode> customRepositoryPlugins) {
-    myUpdatedPlugins = updatedPlugins;
-    myCustomRepositoryPlugins = customRepositoryPlugins;
+    if (UpdateSettings.getInstance().isPluginsCheckNeeded()) {
+      myUpdatedPlugins = updatedPlugins;
+      myCustomRepositoryPlugins = customRepositoryPlugins;
+    }
+    else {
+      myUpdatedPlugins = null;
+    }
     updateState();
   }
 
   private static void newUpdatedPlugins(@Nullable Collection<PluginDownloader> updatedPlugins) {
-    myUpdatedPlugins = updatedPlugins == null || updatedPlugins.isEmpty() ? null : updatedPlugins;
+    myUpdatedPlugins = ContainerUtil.isEmpty(updatedPlugins) ? null : updatedPlugins;
     updateState();
   }