diff --git a/.idea/modules.xml b/.idea/modules.xml index 7a18041af268..22a6602d1bbe 100644 --- a/.idea/modules.xml +++ b/.idea/modules.xml @@ -498,7 +498,6 @@ - diff --git a/build/groovy/org/jetbrains/intellij/build/BaseIdeaProperties.groovy b/build/groovy/org/jetbrains/intellij/build/BaseIdeaProperties.groovy index e11588ba9d3d..02173c4bad55 100644 --- a/build/groovy/org/jetbrains/intellij/build/BaseIdeaProperties.groovy +++ b/build/groovy/org/jetbrains/intellij/build/BaseIdeaProperties.groovy @@ -93,8 +93,7 @@ abstract class BaseIdeaProperties extends ProductProperties { "intellij.java.debugger.streams", "intellij.android.smali", "intellij.statsCollector", - "intellij.vcs.changeReminder", - "intellij.java.knownAnnotations" + "intellij.vcs.changeReminder" ] protected static final Map CE_CLASS_VERSIONS = [ "": "1.8", diff --git a/java/java-impl/src/META-INF/JavaPlugin.xml b/java/java-impl/src/META-INF/JavaPlugin.xml index 8b2ba28ab783..3b12d2cd08fc 100644 --- a/java/java-impl/src/META-INF/JavaPlugin.xml +++ b/java/java-impl/src/META-INF/JavaPlugin.xml @@ -1927,6 +1927,8 @@ + diff --git a/plugins/java-knownAnnotations/src/org/jetbrains/java/knownAnnotations/JBBundledAnnotationsProvider.kt b/java/java-impl/src/com/intellij/codeInsight/externalAnnotation/location/JBBundledAnnotationsProvider.kt similarity index 86% rename from plugins/java-knownAnnotations/src/org/jetbrains/java/knownAnnotations/JBBundledAnnotationsProvider.kt rename to java/java-impl/src/com/intellij/codeInsight/externalAnnotation/location/JBBundledAnnotationsProvider.kt index 1de498271325..d4af076cfdbe 100644 --- a/plugins/java-knownAnnotations/src/org/jetbrains/java/knownAnnotations/JBBundledAnnotationsProvider.kt +++ b/java/java-impl/src/com/intellij/codeInsight/externalAnnotation/location/JBBundledAnnotationsProvider.kt @@ -1,13 +1,13 @@ -package org.jetbrains.java.knownAnnotations +// Copyright 2000-2019 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file. +package com.intellij.codeInsight.externalAnnotation.location import com.google.gson.GsonBuilder import com.google.gson.TypeAdapter import com.google.gson.stream.JsonReader import com.google.gson.stream.JsonToken import com.google.gson.stream.JsonWriter -import com.intellij.codeInsight.externalAnnotation.location.AnnotationsLocation -import com.intellij.codeInsight.externalAnnotation.location.AnnotationsLocationProvider import com.intellij.ide.extensionResources.ExtensionsRootType +import com.intellij.ide.plugins.PluginManagerCore import com.intellij.openapi.extensions.PluginId import com.intellij.openapi.roots.libraries.Library import com.intellij.openapi.util.io.FileUtil @@ -15,7 +15,7 @@ import com.intellij.util.text.VersionComparatorUtil class JBBundledAnnotationsProvider : AnnotationsLocationProvider { - private val myPluginId = PluginId.getId("org.jetbrains.java.knownAnnotations") + private val myPluginId = PluginId.getId(PluginManagerCore.CORE_PLUGIN_ID) private val knownAnnotations: Map> by lazy { buildAnnotations() } override fun getLocations(library: Library, @@ -32,17 +32,6 @@ class JBBundledAnnotationsProvider : AnnotationsLocationProvider { return listOf(matchers.entries.find { it.key.matches(version) }?.value ?: return emptyList()) } - private fun versionMatches(available: String, requested: String): Boolean { - val majorRequested = extractMajor(requested) - val availableWithoutAnSuffix = dropAnSuffix(available) - - return VersionComparatorUtil.compare(majorRequested, available) <= 0 - && VersionComparatorUtil.compare(availableWithoutAnSuffix, requested) <= 0 - } - - private fun extractMajor(versionStr: String): String = versionStr.split('(', ')', '.', '_', '-', ';', ':', '/', ',', ' ', '+', '~')[0] - private fun dropAnSuffix(versionStr: String): String = versionStr.split(Regex("-an[\\d]+$"))[0] - private fun buildAnnotations(): Map> { val extensionsRootType = ExtensionsRootType.getInstance() val annotationsFile = extensionsRootType.findResource(myPluginId, "predefinedExternalAnnotations.json") diff --git a/plugins/java-knownAnnotations/src/extensions/predefinedExternalAnnotations.json b/java/java-impl/src/extensions/predefinedExternalAnnotations.json similarity index 100% rename from plugins/java-knownAnnotations/src/extensions/predefinedExternalAnnotations.json rename to java/java-impl/src/extensions/predefinedExternalAnnotations.json diff --git a/plugins/java-knownAnnotations/test/org/jetbrains/java/knowAnnotatinos/JBBundledAnnotationsProviderTest.kt b/java/java-tests/testSrc/com/intellij/codeInsight/externalAnnotation/location/JBBundledAnnotationsProviderTest.kt similarity index 92% rename from plugins/java-knownAnnotations/test/org/jetbrains/java/knowAnnotatinos/JBBundledAnnotationsProviderTest.kt rename to java/java-tests/testSrc/com/intellij/codeInsight/externalAnnotation/location/JBBundledAnnotationsProviderTest.kt index 63a6fb4133c9..ea4678a567c8 100644 --- a/plugins/java-knownAnnotations/test/org/jetbrains/java/knowAnnotatinos/JBBundledAnnotationsProviderTest.kt +++ b/java/java-tests/testSrc/com/intellij/codeInsight/externalAnnotation/location/JBBundledAnnotationsProviderTest.kt @@ -1,16 +1,13 @@ -package org.jetbrains.java.knowAnnotatinos +// Copyright 2000-2019 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file. +package com.intellij.codeInsight.externalAnnotation.location -import com.intellij.codeInsight.externalAnnotation.location.AnnotationsLocation import com.intellij.openapi.application.WriteAction import com.intellij.openapi.roots.libraries.Library import com.intellij.openapi.roots.libraries.LibraryTablesRegistrar import com.intellij.testFramework.LightPlatformTestCase import org.assertj.core.api.Assertions.assertThat -import org.jetbrains.java.knownAnnotations.JBBundledAnnotationsProvider import org.junit.Test -// Copyright 2000-2019 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file. - class JBBundledAnnotationsProviderTest : LightPlatformTestCase() { diff --git a/plugins/java-knownAnnotations/intellij.java.knownAnnotations.iml b/plugins/java-knownAnnotations/intellij.java.knownAnnotations.iml deleted file mode 100644 index ebdd53fbb045..000000000000 --- a/plugins/java-knownAnnotations/intellij.java.knownAnnotations.iml +++ /dev/null @@ -1,16 +0,0 @@ - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/plugins/java-knownAnnotations/src/META-INF/plugin.xml b/plugins/java-knownAnnotations/src/META-INF/plugin.xml deleted file mode 100644 index 086a50d5e43e..000000000000 --- a/plugins/java-knownAnnotations/src/META-INF/plugin.xml +++ /dev/null @@ -1,16 +0,0 @@ - - - org.jetbrains.java.knownAnnotations - Known annotations provider - - Attaches external annotations artifacts from pre-defined list to libraries imported from Gradle/Maven projects. - - JetBrains - - com.intellij.modules.java - - - - - \ No newline at end of file