diff --git a/plugins/devkit/resources/META-INF/plugin.xml b/plugins/devkit/resources/META-INF/plugin.xml index 8cb1a2db6ee3..871da6062961 100644 --- a/plugins/devkit/resources/META-INF/plugin.xml +++ b/plugins/devkit/resources/META-INF/plugin.xml @@ -65,6 +65,9 @@ + diff --git a/plugins/devkit/resources/inspectionDescriptions/InspectionUniqueToolbarId.html b/plugins/devkit/resources/inspectionDescriptions/InspectionUniqueToolbarId.html new file mode 100644 index 000000000000..2cfacb73187d --- /dev/null +++ b/plugins/devkit/resources/inspectionDescriptions/InspectionUniqueToolbarId.html @@ -0,0 +1,5 @@ + + +

Please specify unique toolbar id

+ + \ No newline at end of file diff --git a/plugins/devkit/src/inspections/UniqueToolbarIdInspection.java b/plugins/devkit/src/inspections/UniqueToolbarIdInspection.java new file mode 100644 index 000000000000..e86eb26ad62b --- /dev/null +++ b/plugins/devkit/src/inspections/UniqueToolbarIdInspection.java @@ -0,0 +1,66 @@ +/* + * Copyright 2000-2017 JetBrains s.r.o. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.jetbrains.idea.devkit.inspections; + +import com.intellij.codeInspection.ProblemsHolder; +import com.intellij.openapi.actionSystem.ActionManager; +import com.intellij.openapi.util.Comparing; +import com.intellij.openapi.util.text.StringUtil; +import com.intellij.psi.*; +import com.intellij.psi.util.PsiTypesUtil; +import org.jetbrains.annotations.NotNull; + +/** + * @author Konstantin Bulenkov + */ +public class UniqueToolbarIdInspection extends DevKitInspectionBase { + @Override + protected PsiElementVisitor buildInternalVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) { + return new JavaElementVisitor() { + @Override + public void visitMethodCallExpression(PsiMethodCallExpression expression) { + PsiMethod method = expression.resolveMethod(); + if (method != null && "createActionToolbar".equals(method.getName())) { + PsiClass aClass = method.getContainingClass(); + if (aClass != null && ActionManager.class.getName().equals(aClass.getQualifiedName())) { + PsiParameter[] parameters = method.getParameterList().getParameters(); + if (parameters.length > 0 && parameters[0].getType() instanceof PsiClassType) { + PsiType type = parameters[0].getType(); + //first check doesn't require resolve + if (Comparing.equal(((PsiClassType)type).getClassName(), CommonClassNames.JAVA_LANG_STRING_SHORT) + && CommonClassNames.JAVA_LANG_STRING.equals(type.getCanonicalText(false))) { + PsiExpression[] expressions = expression.getArgumentList().getExpressions(); + if (expressions.length > 0) { + String text = expressions[0].getText(); + if (text.equals("\"\"") || text.endsWith(".UNKNOWN")) { + holder.registerProblem(expressions[0], "Specify unique toolbar id"); + } + } + } + } + } + } + super.visitMethodCallExpression(expression); + } + }; + } + + @NotNull + @Override + public String getShortName() { + return "InspectionUniqueToolbarId"; + } +} diff --git a/plugins/devkit/testData/inspections/uniqueToolbarId/UniqueToolbarIdTestDataClass.java b/plugins/devkit/testData/inspections/uniqueToolbarId/UniqueToolbarIdTestDataClass.java new file mode 100644 index 000000000000..25ae7902278d --- /dev/null +++ b/plugins/devkit/testData/inspections/uniqueToolbarId/UniqueToolbarIdTestDataClass.java @@ -0,0 +1,8 @@ +import com.intellij.openapi.actionSystem.*; +public class UniqueToolbarIdTestDataClass { + public void foo() { + ActionManager.getInstance().createActionToolbar("asdasd", new ActionGroup(), false); + ActionManager.getInstance().createActionToolbar("", new ActionGroup(), false); + ActionManager.getInstance().createActionToolbar(ActionPlaces.UNKNOWN, new ActionGroup(), false); + } +} \ No newline at end of file diff --git a/plugins/devkit/testSources/inspections/UniqueToolbarIdInspectionTest.java b/plugins/devkit/testSources/inspections/UniqueToolbarIdInspectionTest.java new file mode 100644 index 000000000000..af430773d141 --- /dev/null +++ b/plugins/devkit/testSources/inspections/UniqueToolbarIdInspectionTest.java @@ -0,0 +1,49 @@ +/* + * Copyright 2000-2017 JetBrains s.r.o. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.jetbrains.idea.devkit.inspections; + +import com.intellij.openapi.application.PluginPathManager; +import com.intellij.testFramework.TestDataPath; + +/** + * @author Konstantin Bulenkov + */ +@TestDataPath("$CONTENT_ROOT/testData/inspections/uniqueToolbarId") +public class UniqueToolbarIdInspectionTest extends PluginModuleTestCase { + + @Override + protected String getBasePath() { + return PluginPathManager.getPluginHomePathRelative("devkit") + "/testData/inspections/uniqueToolbarId"; + } + + @Override + protected void setUp() throws Exception { + super.setUp(); + myFixture.enableInspections(UniqueToolbarIdInspection.class); + myFixture.addClass("package com.intellij.openapi.actionSystem; public class ActionToolbar {}"); + myFixture.addClass("package com.intellij.openapi.actionSystem; public class ActionGroup {}"); + myFixture.addClass("package com.intellij.openapi.actionSystem; public class ActionPlaces {public static final String UNKNOWN = \"\";}"); + myFixture.addClass("package com.intellij.openapi.actionSystem; " + + "public class ActionManager {" + + "public static ActionManager getInstance() {return new ActionManager();}" + + "public ActionToolbar createActionToolbar(@NonNls String place, @NotNull ActionGroup group, boolean horizontal) {return new ActionToolbar();}" + + "}"); + } + + public void testUsingEmptyToolbarId() throws Exception { + myFixture.testHighlighting("UniqueToolbarIdTestDataClass.java"); + } +}